CLI code refactor #665

vibhorgupta-gh · 2019-01-12T11:13:20Z

Fixes #658

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

jywarren

This is great!!!

jywarren · 2019-01-12T13:42:35Z

There's a let based error in node 4, however. I think there's an issue open but we should be able to set strict mode and resolve it. What do you think?

Great work!!!

vibhorgupta-gh · 2019-01-12T13:59:12Z

@jywarren using strict is always good, let's do it!
However, is the let based error affecting this PR too? I don't think it is..

harshkhandeparkar · 2019-01-12T14:02:30Z

@jywarren we can compile the CLI code using NectarJS

harshkhandeparkar · 2019-01-22T20:05:57Z

index.js

    if (err) exit("Can't read file.");
  });

  // User must input a step. If steps exist, check that every step is a valid step.
-  if (!program.step || !validateSteps(program.step))
+  if (!program.step || !(require('./src/CliUtils').validateSteps(program.step, sequencer)))


How about requiring everything at the start of the file for consistency?

Oh yes, I didn't pay attention. Will do

index.js

jywarren

This looks good, perhaps I'd like one more review from someone, and a rebase? Thanks a lot, this is exciting!!!

jywarren · 2019-01-24T00:18:47Z

Hmm, is Travis stuck?

Mridul97

Looks good! :)

vibhorgupta-gh · 2019-01-24T19:38:27Z

@Mridul97 @jywarren Travis seems to be stuck. Any ideas?

harshkhandeparkar · 2019-01-24T19:39:42Z

@VibhorCodecianGupta try running the tests locally and see if anything pops up

harshkhandeparkar · 2019-01-24T19:40:14Z

Maybe infinite recursion of require ?

harshkhandeparkar · 2019-01-24T19:41:25Z

Did you try using the new CLI code locally? See if it gets stuck

vibhorgupta-gh · 2019-01-24T19:50:16Z

@harshkhandeparkar checked and rechecked, everything's fine. #650 and #696 face similar issues

harshkhandeparkar · 2019-01-24T19:52:20Z

Is that because node 4 support was dropped? Maybe the travis file is broken somehow

harshkhandeparkar · 2019-01-24T19:56:18Z

Is your forked travis file counted? Or only the upstream file is counted?

harshkhandeparkar · 2019-01-24T19:58:11Z

Oh the progress can be seen. It seems like it is stuck at upgrading system packages of some sort.

vibhorgupta-gh · 2019-01-24T20:19:46Z

@jywarren @harshkhandeparkar Travis was just behaving weirdly I guess? The last two commits are just do/undo commits and the job kickstarted again. Travis passes now. I think we can merge this now?

harshkhandeparkar · 2019-01-24T20:20:25Z

Yes I saw that. Maybe it was a travis bug of some sort.

harshkhandeparkar · 2019-01-24T20:21:16Z

#696 is still in progress though. Maybe any commit would reset the procedure and fix this?

vibhorgupta-gh · 2019-01-24T20:22:26Z

@harshkhandeparkar I guess that's it. Once the job kickstarts again, Travis resumes.
Also, could you review the changes?

harshkhandeparkar

✔️ . Please share a GIF if possible

vibhorgupta-gh · 2019-01-24T20:28:37Z

Here is a screenshot. I'm on a slow internet here 😅
Do mention if a GIF is required. Tested, everything works fine

harshkhandeparkar · 2019-01-24T20:31:54Z

No need of a GIF. Thanks! Looks good!

harshkhandeparkar · 2019-01-24T20:35:04Z

I'm on a slow internet here

Same here. I'm using BSNL so no hopes for the next 💯 years. The latency is more than what it would take to compile image-sequencer.

vibhorgupta-gh · 2019-01-31T10:10:55Z

@jywarren I think this is a complete blob of work. Thoughts?

jywarren · 2019-01-31T18:01:11Z

Looks good! Merging now, and great work, again!

* fix insert step button * add dist * add new function * remove console logs * refactor * Setup UI testing (#720) * default sequencer ui test * default step ui test suite * intermediate step ui test * preview ui test suite * url methods test suite * add set url params method test suite * argument call tests * test directory refactor * travis fix * CLI code refactor (#665) * CLI refactor * es6 rollback * Travis fix * syntax fix * clustered require statements * travis debug * travis debug * Added line that selects the "More modules..." after adding a step. (#713) * Added line making module selection correct after adding a step * Added line with appropriate module selection * Add: Module tests (#748) * WIP * module testing harness * adjustments * Update package-lock.json * Bump jsqr from 1.1.1 to 1.2.0 (#749) Bumps [jsqr](https://github.com/cozmo/jsQR) from 1.1.1 to 1.2.0. - [Release notes](https://github.com/cozmo/jsQR/releases) - [Commits](https://github.com/cozmo/jsQR/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * refactor without spread syntax

* update dist Signed-off-by: tech4GT <varun.gupta1798@gmail.com> dist update Revert "dist update" This reverts commit 9ee2a98. * fix insert step button * add icon * add dist * use normal functions * use normal functions * add new function * add dist * remove console logs * changes * refactor * add dist * Bump looks-same from 5.0.2 to 6.0.0 (#729) Bumps [looks-same](https://github.com/gemini-testing/looks-same) from 5.0.2 to 6.0.0. - [Release notes](https://github.com/gemini-testing/looks-same/releases) - [Changelog](https://github.com/gemini-testing/looks-same/blob/master/CHANGELOG.md) - [Commits](gemini-testing/looks-same@v5.0.2...v6.0.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * Setup UI testing (#720) * default sequencer ui test * default step ui test suite * intermediate step ui test * preview ui test suite * url methods test suite * add set url params method test suite * argument call tests * test directory refactor * travis fix * CLI code refactor (#665) * CLI refactor * es6 rollback * Travis fix * syntax fix * clustered require statements * travis debug * travis debug * Added line that selects the "More modules..." after adding a step. (#713) * Added line making module selection correct after adding a step * Added line with appropriate module selection * Add: Module tests (#748) * WIP * module testing harness * adjustments * Fix choose file option and insert step functionality (#712) * Fix choose file option * changes * Parse info.json to set module defaults (#650) * changes * changes * changes * changes * changes * changes * Update package-lock.json * Bump jsqr from 1.1.1 to 1.2.0 (#749) Bumps [jsqr](https://github.com/cozmo/jsQR) from 1.1.1 to 1.2.0. - [Release notes](https://github.com/cozmo/jsQR/releases) - [Commits](https://github.com/cozmo/jsQR/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump jsqr from 1.1.1 to 1.2.0 (#749) Bumps [jsqr](https://github.com/cozmo/jsQR) from 1.1.1 to 1.2.0. - [Release notes](https://github.com/cozmo/jsQR/releases) - [Commits](https://github.com/cozmo/jsQR/commits) Signed-off-by: dependabot[bot] <support@dependabot.com> * dist * changes * working * final touches * revert mapTypes * proper revert * Fix arctangent * working hysteresis * hysteresis optional

vibhorgupta-gh added 2 commits January 12, 2019 16:38

CLI refactor

db4292d

es6 rollback

d04dd8b

vibhorgupta-gh changed the title ~~Test~~ CLI code refactor Jan 12, 2019

This was referenced Jan 12, 2019

use require() in index.js to source from /src/cli/ #658

Closed

CLI error did not trigger a Travis failure #659

Closed

Travis fix

36c0725

vibhorgupta-gh force-pushed the test branch from 1547200 to 36c0725 Compare January 12, 2019 11:34

vibhorgupta-gh requested a review from jywarren January 12, 2019 11:40

jywarren approved these changes Jan 12, 2019

View reviewed changes

syntax fix

3ef7048

jywarren mentioned this pull request Jan 17, 2019

Remove logs in console. #678

Closed

5 tasks

harshkhandeparkar reviewed Jan 22, 2019

View reviewed changes

clustered require statements

6eac5f8

vibhorgupta-gh force-pushed the test branch from 5195ed9 to 6eac5f8 Compare January 23, 2019 07:27

jywarren approved these changes Jan 23, 2019

View reviewed changes

vibhorgupta-gh requested review from tech4GT and Mridul97 January 24, 2019 07:34

rebase

f1cf358

Mridul97 approved these changes Jan 24, 2019

View reviewed changes

vibhorgupta-gh force-pushed the test branch from c796723 to f1cf358 Compare January 24, 2019 20:02

vibhorgupta-gh added 2 commits January 25, 2019 01:33

travis debug

cd3cd3a

travis debug

7fe1c8b

vibhorgupta-gh requested a review from harshkhandeparkar January 24, 2019 20:21

harshkhandeparkar approved these changes Jan 24, 2019

View reviewed changes

vibhorgupta-gh removed the request for review from tech4GT January 26, 2019 07:10

vibhorgupta-gh added the ready-to-merge label Jan 31, 2019

jywarren merged commit d0bf9de into publiclab:main Jan 31, 2019

jywarren mentioned this pull request Feb 9, 2019

Map types to html types #754

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLI code refactor #665

CLI code refactor #665

vibhorgupta-gh commented Jan 12, 2019 •

edited

Loading

jywarren left a comment

jywarren commented Jan 12, 2019

vibhorgupta-gh commented Jan 12, 2019

harshkhandeparkar commented Jan 12, 2019

harshkhandeparkar Jan 22, 2019

vibhorgupta-gh Jan 23, 2019

jywarren left a comment

jywarren commented Jan 24, 2019

Mridul97 left a comment

vibhorgupta-gh commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

vibhorgupta-gh commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

vibhorgupta-gh commented Jan 24, 2019 •

edited

Loading

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

vibhorgupta-gh commented Jan 24, 2019

harshkhandeparkar left a comment •

edited

Loading

vibhorgupta-gh commented Jan 24, 2019 •

edited

Loading

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

vibhorgupta-gh commented Jan 31, 2019

jywarren commented Jan 31, 2019

CLI code refactor #665

CLI code refactor #665

Conversation

vibhorgupta-gh commented Jan 12, 2019 • edited Loading

jywarren left a comment

Choose a reason for hiding this comment

jywarren commented Jan 12, 2019

vibhorgupta-gh commented Jan 12, 2019

harshkhandeparkar commented Jan 12, 2019

harshkhandeparkar Jan 22, 2019

Choose a reason for hiding this comment

vibhorgupta-gh Jan 23, 2019

Choose a reason for hiding this comment

jywarren left a comment

Choose a reason for hiding this comment

jywarren commented Jan 24, 2019

Mridul97 left a comment

Choose a reason for hiding this comment

vibhorgupta-gh commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

vibhorgupta-gh commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

vibhorgupta-gh commented Jan 24, 2019 • edited Loading

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

vibhorgupta-gh commented Jan 24, 2019

harshkhandeparkar left a comment • edited Loading

Choose a reason for hiding this comment

vibhorgupta-gh commented Jan 24, 2019 • edited Loading

harshkhandeparkar commented Jan 24, 2019

harshkhandeparkar commented Jan 24, 2019

vibhorgupta-gh commented Jan 31, 2019

jywarren commented Jan 31, 2019

vibhorgupta-gh commented Jan 12, 2019 •

edited

Loading

vibhorgupta-gh commented Jan 24, 2019 •

edited

Loading

harshkhandeparkar left a comment •

edited

Loading

vibhorgupta-gh commented Jan 24, 2019 •

edited

Loading