Complete Edge Detect Module #771

harshkhandeparkar · 2019-02-14T12:37:54Z

Fixes #176

Hysteresis is implemented(it slows down the browsers very significantly)
Black background
General refactoring

It Works!!

Old:

This output had a lot of transparency(alpha = 0)
Thick edges
No hysteresis

New:

Black background
No transparency
Pure white edges
Thin edges

Note: The default high and low threshold ratio values are not necessarily meant to be the best. They are to be found empirically for different cases.

Note: Higher high threshold takes less time to process but it's lossier (some edges are neglected).

Note: Lower low/high threshold takes very long to process and can render a browser unresponsive.

Note: Low threshold ratio can be greater than the high threshold ratio since it is multiplied to the high threshold value. i.e `low_threshold_ratio = low_threshold_value/high_threshold_value` and `high_threshold_ratio = high_threshold_value/maximum_gradient`

Note: Here value is the actual value which is compared to the gradients and ratio is a relative ratio of different values.

It is slow though

It takes very long to iterate through all the edges. This algorithm/module should be mainly used on servers. This can benefit a lot from the REST API project which is under development.

@publiclab/is-reviewers @jywarren

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
code is in uniquely-named feature branch and has no merge conflicts
PR is descriptively titled
ask @publiclab/reviewers and @publiclab/is-reviewers for help, in a comment below

Thanks!

Signed-off-by: tech4GT <varun.gupta1798@gmail.com> dist update Revert "dist update" This reverts commit 9ee2a98.

Conflicts: dist/image-sequencer-ui.min.js dist/image-sequencer.js dist/image-sequencer.min.js src/modules/PaintBucket/info.json src/modules/Rotate/info.json

Bumps [looks-same](https://github.com/gemini-testing/looks-same) from 5.0.2 to 6.0.0. - [Release notes](https://github.com/gemini-testing/looks-same/releases) - [Changelog](https://github.com/gemini-testing/looks-same/blob/master/CHANGELOG.md) - [Commits](gemini-testing/looks-same@v5.0.2...v6.0.0) Signed-off-by: dependabot[bot] <support@dependabot.com>

* default sequencer ui test * default step ui test suite * intermediate step ui test * preview ui test suite * url methods test suite * add set url params method test suite * argument call tests * test directory refactor * travis fix

* CLI refactor * es6 rollback * Travis fix * syntax fix * clustered require statements * travis debug * travis debug

) * Added line making module selection correct after adding a step * Added line with appropriate module selection

* WIP * module testing harness * adjustments

* Fix choose file option * changes

* changes * changes * changes * changes * changes * changes

jywarren · 2019-03-15T18:34:20Z

Ah, did you manage to add the addition so that hysteresis defaults to false, and is an option (with checkbox?) Thank you!!!

harshkhandeparkar · 2019-03-15T18:35:36Z

I will add everything as soon as I get time so I was asking for all the required suggestions.

harshkhandeparkar · 2019-03-17T05:31:04Z

@jywarren I have rebased and made all the changes. A demo will be available here

harshkhandeparkar · 2019-03-17T05:31:27Z

Please try to merge this before the others. Thank you!

harshkhandeparkar · 2019-03-17T05:32:06Z

Oh yea, please be sure to clear the cache.

harshkhandeparkar · 2019-03-17T05:40:11Z

An updated link demo will be available here. Sorry for the inconvenience.

harshkhandeparkar · 2019-03-17T05:44:44Z

@jywarren I think this is ready to merge. I have checked everything. It works. Below is hysteresis v/s non-hysteresis comparison(left image is without hysteresis).

Thank You!

cc @tech4GT @publiclab/is-reviewers

harshithpabbati · 2019-03-17T05:45:11Z

Hey Harsh the UI looks different in mobile.

harshkhandeparkar · 2019-03-17T05:46:02Z

Hello harshith, try clearing the cache and do not use the new UI. And css will be fixed by @aashna27

harshithpabbati · 2019-03-17T05:50:00Z

EDIT: image removed as it covers the whole screen
check this out. I cleared the cache.

harshkhandeparkar · 2019-03-17T05:51:58Z

I removed your image because it was covering the screen. That issue will be fixed by @aashna27 in #867

harshithpabbati · 2019-03-17T06:00:24Z

If you want I can make the changes in css.

harshkhandeparkar · 2019-03-17T06:13:08Z

Atleast not now. As I turned off my pc and won't be able to do anything. You can open a pr in my gh-pages branch if you want

harshkhandeparkar · 2019-03-17T06:14:06Z

This current PR focuses on edgeDetect so css isn't much important. If you still want to improve the demo, you can. Thank you.

jywarren

This looks great; I did find a small typo. Did you want to add a quick test to this using looks-like to protect it against future bugs? I think that's a really good idea now that the project is becoming more complex. Thanks!

src/modules/EdgeDetect/Module.js

jywarren · 2019-03-17T20:46:52Z

And noting that it passed in almost the same amount of time:

this branch: Module edge-detect ran in: 2672 milliseconds
main: Module edge-detect ran in: 2709 milliseconds

harshkhandeparkar · 2019-03-17T20:51:24Z

It takes a lot less time without hysteresis. Maybe it ran faster here as there is no different gradient and there are less pixels to be preserved. I.e binary image. I'm not sure though.

harshkhandeparkar · 2019-03-17T20:52:33Z

For the tests, maybe we can open an issue for creation of looks-same tests for all modules.

jywarren · 2019-03-17T20:53:59Z

Hi Harsh, i'm OK with merging this without a test, but I think in general we should be transitioning to requiring a test with every module before merging it, rather than doing it in follow-up, as a matter of policy. What do you think?

harshkhandeparkar · 2019-03-17T20:56:32Z

Yes sure. Thanks. I can add tests to all the remaining modules once I am free and maybe add the new policy to the contributing file.

jywarren · 2019-03-17T21:05:38Z

Great, thank you! Really nice work here!

harshkhandeparkar · 2019-03-17T21:07:19Z

Thanks a lot!!! @harshithpabbati this was just merged. Try running tge update script when you get time. Let's see if the changes are visible there.

harshithpabbati · 2019-03-18T04:46:20Z

Sure @harshkhandeparkar I will run it now.

tech4GT and others added 30 commits December 27, 2018 19:00

update dist

8e8281a

Signed-off-by: tech4GT <varun.gupta1798@gmail.com> dist update Revert "dist update" This reverts commit 9ee2a98.

Merge remote-tracking branch 'upstream/main' into main

4774f8f

Merge remote-tracking branch 'upstream/main' into main

305b45b

Merge remote-tracking branch 'upstream/main' into main

61a7c5d

fix insert step button

a66e115

add icon

9f7386f

add dist

40b1987

use normal functions

1e29033

use normal functions

8db9d9c

merge with main

2b0c82a

add new function

14b8bcc

add dist

dd5e336

remove console logs

be99ea7

changes

ac45793

merge with main

b905068

merge with main

9aa5841

merge with main

c32b94d

Merge remote-tracking branch 'upstream/main' into map-types-to-htmlTypes

e0f4bc3

refactor

b364b0c

Merge remote-tracking branch 'upstream/main' into map-types-to-htmlTypes

a35a20c

Merge remote-tracking branch 'refs/remotes/upstream/main'

0953e2f

Conflicts: dist/image-sequencer-ui.min.js dist/image-sequencer.js dist/image-sequencer.min.js src/modules/PaintBucket/info.json src/modules/Rotate/info.json

add dist

b79680d

Setup UI testing (#720)

743fa4b

* default sequencer ui test * default step ui test suite * intermediate step ui test * preview ui test suite * url methods test suite * add set url params method test suite * argument call tests * test directory refactor * travis fix

CLI code refactor (#665)

50265f5

* CLI refactor * es6 rollback * Travis fix * syntax fix * clustered require statements * travis debug * travis debug

Added line that selects the "More modules..." after adding a step. (#713

7ce89a8

) * Added line making module selection correct after adding a step * Added line with appropriate module selection

Add: Module tests (#748)

996afac

* WIP * module testing harness * adjustments

Fix choose file option and insert step functionality (#712)

a1a698e

* Fix choose file option * changes

Parse info.json to set module defaults (#650)

14c228d

* changes * changes * changes * changes * changes * changes

Update package-lock.json

0859d61

harshkhandeparkar requested review from a team and removed request for Mridul97 March 14, 2019 17:02

HarshKhandeparkar added 2 commits March 17, 2019 10:44

hysteresis optional

f5dadb0

edge detect complete

8b1ce95

harshkhandeparkar added the ready-to-merge label Mar 17, 2019

jywarren requested changes Mar 17, 2019

View reviewed changes

src/modules/EdgeDetect/Module.js Show resolved Hide resolved

jywarren merged commit c645732 into publiclab:main Mar 17, 2019

harshkhandeparkar deleted the complete-edge-detect branch June 7, 2019 17:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Complete Edge Detect Module #771

Complete Edge Detect Module #771

harshkhandeparkar commented Feb 14, 2019 •

edited

Loading

jywarren commented Mar 15, 2019

harshkhandeparkar commented Mar 15, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019 •

edited

Loading

harshkhandeparkar commented Mar 17, 2019

harshithpabbati commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshithpabbati commented Mar 17, 2019 •

edited by harshkhandeparkar

Loading

harshkhandeparkar commented Mar 17, 2019

harshithpabbati commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

jywarren left a comment

jywarren commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

jywarren commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

jywarren commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshithpabbati commented Mar 18, 2019

Complete Edge Detect Module #771

Complete Edge Detect Module #771

Conversation

harshkhandeparkar commented Feb 14, 2019 • edited Loading

It Works!!

Note: The default high and low threshold ratio values are not necessarily meant to be the best. They are to be found empirically for different cases.

Note: Higher high threshold takes less time to process but it's lossier (some edges are neglected).

Note: Lower low/high threshold takes very long to process and can render a browser unresponsive.

Note: Low threshold ratio can be greater than the high threshold ratio since it is multiplied to the high threshold value. i.e low_threshold_ratio = low_threshold_value/high_threshold_value and high_threshold_ratio = high_threshold_value/maximum_gradient

Note: Here value is the actual value which is compared to the gradients and ratio is a relative ratio of different values.

It is slow though

Thanks!

jywarren commented Mar 15, 2019

harshkhandeparkar commented Mar 15, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019 • edited Loading

harshkhandeparkar commented Mar 17, 2019

Thank You!

harshithpabbati commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshithpabbati commented Mar 17, 2019 • edited by harshkhandeparkar Loading

harshkhandeparkar commented Mar 17, 2019

harshithpabbati commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

jywarren left a comment

Choose a reason for hiding this comment

jywarren commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

jywarren commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

jywarren commented Mar 17, 2019

harshkhandeparkar commented Mar 17, 2019

harshithpabbati commented Mar 18, 2019

harshkhandeparkar commented Feb 14, 2019 •

edited

Loading

Note: Low threshold ratio can be greater than the high threshold ratio since it is multiplied to the high threshold value. i.e `low_threshold_ratio = low_threshold_value/high_threshold_value` and `high_threshold_ratio = high_threshold_value/maximum_gradient`

harshkhandeparkar commented Mar 17, 2019 •

edited

Loading

harshithpabbati commented Mar 17, 2019 •

edited by harshkhandeparkar

Loading