Deep links load content hidden underneath our menu bar and ribbon

[ebarry]

Please describe the problem (or idea)

What happened just before the problem occurred?

I clicked the timestamp to a particular comment i needed to link to, and it created this URL that loaded the content so high that it was completely hidden under the menu bar or the ribbon. Luckily, I knew what i was expecting to see , so i knew to scroll up to find it, but someone who doesn't know what to expect when clicking the link could get completely confused because of this.

What did you expect to see that you didn't?

I expected to see the top of the content i linked to.

Please show us where to look

https://publiclab.org/questions/warren/11-14-2017/what-s-one-thing-that-could-be-better-for-newcomers-about-the-public-lab-website#answer-0-comment-17687

Here's an example matching the screenshot below: https://publiclab.org/wiki/public-comment#What+is+Public+Comment?

[jywarren]

We attempted a fix here:

plots2/app/assets/javascripts/setup.js

Lines 46 to 55 in ceb7d05

	/* window scroll trick for header */
	function adjust_anchor_for_banner(offset) {
	offset = offset || 50; // how much to scroll to account for the banner
	var scroll_pos = $(document).scrollTop()
	if (scroll_pos > offset) {
	$(document).scrollTop( scroll_pos - offset );
	}
	}
	$(window).load(function() { adjust_anchor_for_banner(); })
	$(window).on('hashchange', adjust_anchor_for_banner)

But this isn't great. Would it work if we just increased the "rewind" by... 100+ pixels?

Also, there are at least two ways to get to one of these -- our solution should work for all of them:

• Direct: by clicking a link like https://publiclab.org/questions/warren/11-14-2017/what-s-one-thing-that-could-be-better-for-newcomers-about-the-public-lab-website#answer-0-comment-17687
• In-page: by clicking a link like #answer-0-comment-17687 within a page

[jywarren]

Fixed for wiki headings here: #2512 by @patcon -- thanks! 👍 👍 🎉

please test this out!

Related work by @namangupta01 here for Answers: #2146