Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected position of Deep links load content #2146

Closed
wants to merge 1 commit into from

Conversation

namangupta01
Copy link
Member

@namangupta01 namangupta01 commented Jan 27, 2018

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
Closes #2093

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@PublicLabBot
Copy link

PublicLabBot commented Jan 27, 2018

2 Messages
📖 @namangupta01 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@namangupta01
Copy link
Member Author

ezgif com-video-to-gif 2

@jywarren
Copy link
Member

jywarren commented Feb 1, 2018

Aha, this is cool -- but I want to note that people may arrive at this URL also by simply clicking on a URL like this one --

https://publiclab.org/questions/asnow/01-23-2018/prefered-slit-size#a733

See how the #a733 leads directly to the answer? So it's not as much about animating on a click, as making sure the page scrolls down. Do you think this could also be triggered on pageload, so as to ensure this loads then too?

Thanks for the animation, it really helps here!

@SidharthBansal
Copy link
Member

Hi @jywarren #2512 is merged now and #2093 is closed so can we close this also??

@patcon
Copy link
Contributor

patcon commented Mar 26, 2018

Whoa! Hey @namangupta01, I was the one who submitted that other PR without seeing yours (sorry for not collaborating!), but I just wanted to say that your GIF tactic is really inspiring. I'm going to try to do that more :)

@namangupta01
Copy link
Member Author

Haha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants