Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Pick a reaction" text to reaction dropdown on comment #4993

Closed
5 tasks
grvsachdeva opened this issue Mar 10, 2019 · 12 comments · Fixed by #8558
Closed
5 tasks

Add "Pick a reaction" text to reaction dropdown on comment #4993

grvsachdeva opened this issue Mar 10, 2019 · 12 comments · Fixed by #8558
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML

Comments

@grvsachdeva
Copy link
Member

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

Add the text "Pick a reaction" in reaction dropdown just like GitHub have 👇
reaction_text

Our current reaction dropdown look 👇
current_pl

Feel free to optimize UI of dropdown further too.

Also, attach the screenshot of the updated view by going over to any research note/question on localhost and taking a screenshot of the comment posted over there

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@grvsachdeva grvsachdeva added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML CSS labels Mar 10, 2019
@grvsachdeva
Copy link
Member Author

This issue is created for @TANGL3SIT3S. Thanks!

@tevinmc
Copy link

tevinmc commented Mar 10, 2019

Hello, I'm new to this codebase and to contributing to open source. Is this issue already claimed and if so can I assist?

@Jaya738
Copy link

Jaya738 commented Mar 11, 2019

Is this issue claimed or I can still work on it?

@grvsachdeva
Copy link
Member Author

Hi @letnewKid @Jaya738 this issue is assigned to @TANGL3SIT3S as they were waiting for their FTO for some time. But, we would love to have help from both of you too.

@Jaya738 I think you got FTO to work with, right?

@letnewKid you can work with @@TANGL3SIT3S on this one, if they don't mind. Or, I can create a new FTO for you too. Thanks!

@tevinmc
Copy link

tevinmc commented Mar 11, 2019

@gauravano I'm an outreachy applicant and I guess don't know if it counts if I work with someone when I record my contribution. But I will reach out to @TANGL3SIT3S.

@grvsachdeva
Copy link
Member Author

Oh! Let's not complicate the case for Outreachy organizers. I will create a separate issue for you. Added your name to the list - #4963 and will ping you soon. Thanks!

@tevinmc
Copy link

tevinmc commented Mar 11, 2019

Thank you so much Gauravano.

@Jenniline
Copy link

Hello @gauravano I am an outreachy applicant new to open source and willing to learn. Please can i have a FTO task as well.

@metonymic-smokey
Copy link
Contributor

@gauravano is this issue still open? Would be willing to try and work on it!

Thanks!

@jywarren
Copy link
Member

jywarren commented Aug 30, 2019 via email

@stale stale bot added stale and removed stale labels Oct 7, 2020
@Shreets
Copy link
Contributor

Shreets commented Oct 8, 2020

Hello, I am an Outreachy applicant and I am picking this issue. I'm going to try work on this

@jywarren
Copy link
Member

jywarren commented Oct 8, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS first-timers-only They need to be well-formatted using the First-timers_Issue_Template. HTML
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants