Add "Pick a reaction" header title to emoji dialog box and update display style. #8558

Shreets · 2020-10-13T10:53:33Z

Add 'Pick a reaction' header to emoji dialog box.
Add margin/padding and flex display to emoji style.
Add hover effect to scale emojis.

PR is descriptively titled 📑 and links the original issue above 🔗
tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
code is in uniquely-named feature branch and has no merge conflicts 📁
screenshots/GIFs are attached 📎 in case of UI updation
ask @publiclab/reviewers for help, in a comment below

@publiclab/reviewers Please review.
Thank you!

Add 'Pick a reaction' header to emoji dialog box. Update emoji display style Add hover effect to emojis.

welcome · 2020-10-13T10:53:35Z

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

gitpod-io · 2020-10-13T10:53:37Z

codecov · 2020-10-13T10:57:47Z

Codecov Report

Merging #8558 into main will decrease coverage by 0.24%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main    #8558      +/-   ##
==========================================
- Coverage   82.01%   81.76%   -0.25%     
==========================================
  Files         101      101              
  Lines        5894     5901       +7     
==========================================
- Hits         4834     4825       -9     
- Misses       1060     1076      +16

Impacted Files	Coverage Δ
app/helpers/search_helper.rb	`100.00% <ø> (ø)`
app/controllers/stats_controller.rb	`71.87% <50.00%> (-1.76%)`	⬇️
app/mailers/comment_mailer.rb	`100.00% <100.00%> (ø)`
app/mailers/subscription_mailer.rb	`94.33% <100.00%> (+0.22%)`	⬆️
app/models/answer.rb	`73.68% <0.00%> (-26.32%)`	⬇️
app/models/answer_selection.rb	`31.25% <0.00%> (-6.25%)`	⬇️
app/services/execute_search.rb	`88.88% <0.00%> (-5.56%)`	⬇️
app/api/srch/search.rb	`66.87% <0.00%> (-3.83%)`	⬇️

jywarren

This looks great and happy to merge! One possible note to change the classname, but not required! Thank you so much!

jywarren · 2020-10-13T15:55:11Z

app/views/notes/_comment.html.erb

  }

  .grow {
-    transition: all .1s ease-in-out;
+    transition: transform .15s cubic-bezier(.2,0,.13,2);


wow, fancy!!! ❤️ 🤯

app/views/notes/_comment.html.erb

jywarren · 2020-10-13T15:58:33Z

So, I think this is good to go, but can hold off a little if you'd like to change the classname -- your choice! Thanks!

sagarpreet-chadha

Wooow 🎉

app/views/notes/_comment.html.erb

Shreets · 2020-10-13T16:19:19Z

So, I think this is good to go, but can hold off a little if you'd like to change the classname -- your choice! Thanks!

@jywarren @sagarpreet-chadha Thank you for pointing that out. I will make this change and update the PR right away.

codeclimate · 2020-10-13T16:26:19Z

Code Climate has analyzed commit 23c8284 and detected 0 issues on this pull request.

View more on Code Climate.

Sagarpreet

🎉

cesswairimu · 2020-10-13T18:06:09Z

wow amazing 🎉

welcome · 2020-10-16T15:07:28Z

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

jywarren · 2020-10-16T15:07:30Z

Great work!!!!!!!!!! 🎉

…play style. (publiclab#8558) * Add Title to emoji display and update display style. Add 'Pick a reaction' header to emoji dialog box. Update emoji display style Add hover effect to emojis. * change classname for div containing emojis

Add Title to emoji display and update display style.

e550648

Add 'Pick a reaction' header to emoji dialog box. Update emoji display style Add hover effect to emojis.

Shreets requested a review from a team as a code owner October 13, 2020 10:53

jywarren approved these changes Oct 13, 2020

View reviewed changes

sagarpreet-chadha approved these changes Oct 13, 2020

View reviewed changes

app/views/notes/_comment.html.erb Outdated Show resolved Hide resolved

change classname for div containing emojis

23c8284

Sagarpreet approved these changes Oct 13, 2020

View reviewed changes

jywarren merged commit 412e918 into publiclab:main Oct 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add "Pick a reaction" header title to emoji dialog box and update display style. #8558

Add "Pick a reaction" header title to emoji dialog box and update display style. #8558

Shreets commented Oct 13, 2020 •

edited

Loading

welcome bot commented Oct 13, 2020

gitpod-io bot commented Oct 13, 2020 •

edited

Loading

codecov bot commented Oct 13, 2020 •

edited

Loading

jywarren left a comment

jywarren Oct 13, 2020

jywarren commented Oct 13, 2020

sagarpreet-chadha left a comment

Shreets commented Oct 13, 2020

codeclimate bot commented Oct 13, 2020

Sagarpreet left a comment

cesswairimu commented Oct 13, 2020

welcome bot commented Oct 16, 2020

jywarren commented Oct 16, 2020

Add "Pick a reaction" header title to emoji dialog box and update display style. #8558

Add "Pick a reaction" header title to emoji dialog box and update display style. #8558

Conversation

Shreets commented Oct 13, 2020 • edited Loading

welcome bot commented Oct 13, 2020

gitpod-io bot commented Oct 13, 2020 • edited Loading

codecov bot commented Oct 13, 2020 • edited Loading

Codecov Report

jywarren left a comment

Choose a reason for hiding this comment

jywarren Oct 13, 2020

Choose a reason for hiding this comment

jywarren commented Oct 13, 2020

sagarpreet-chadha left a comment

Choose a reason for hiding this comment

Shreets commented Oct 13, 2020

codeclimate bot commented Oct 13, 2020

Sagarpreet left a comment

Choose a reason for hiding this comment

cesswairimu commented Oct 13, 2020

welcome bot commented Oct 16, 2020

jywarren commented Oct 16, 2020

Shreets commented Oct 13, 2020 •

edited

Loading

gitpod-io bot commented Oct 13, 2020 •

edited

Loading

codecov bot commented Oct 13, 2020 •

edited

Loading