"Save" not working on /features

[ebarry]

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?
As an Admin, I edited text in a Feature, then clicked Save. The page reloaded with a "This page does not exist" screen, see screenshot. I also tested clicking "Save" without editing, with the same result.

What did you expect to see that you didn't?
I expected to see my edits successfully saved.

Please show us where to look

https://publiclab.org/features/17211
https://publiclab.org/features/11796/
and for Jeff: https://publiclab.slack.com/archives/CV7KG8MFT/p1617198609007000

What's your PublicLab.org username?

bhamster
liz

Thank you!

[daemon1024]

Noting some finding that may assist in solving this.

When we try to edit and save in local development environment, the route seems to throwing off an exception.

No route matches [POST] "/features/<id>"

It should be calling update features controllers.

plots2/app/views/features/edit.html.erb

Line 1 in 9e66b0f

<% url = { :controller => "features", :action => "update", :id => @node.id } %>

plots2/app/controllers/features_controller.rb

Line 68 in 9e66b0f

def update

the update controller hasn't been updated for quite a while so not exactly sure what changed that is throwing off this exception now.

[jywarren]

Wow very much appreciated! I got drawn into an adjacent bug 😅

[jywarren]

I'll check the routes.rb file!

[jywarren]

https://github.com/publiclab/plots2/blame/main/config/routes.rb

[jywarren]

This line is 6 years old, so i doubt it's related!

https://github.com/publiclab/plots2/blame/9e66b0f1a7c19733388d233308d2b090111bc627/app/views/features/edit.html.erb#L1

[jywarren]

I really don't see much in routes.rb...

[daemon1024]

I checked the the routes, there's no POST method for features/:id

[daemon1024]

https://stackoverflow.com/questions/19501374/rails-4-routingerror-no-route-matches-post This might be related

[jywarren]

indeed. i think it probably uses a more general matcher, or is implicit since it's a resource?

plots2/config/routes.rb

Line 23 in 9e66b0f

resources :features

[jywarren]

The broken feature was last edited 2 months ago so i'm thinking there have only been a couple site republishes since then anyways! So strange!

[daemon1024]

I will look into if we had any changes in the node model, since the stackoverflow solution seems to be pointing towards there.

[jywarren]

Aha, i like your theory on the form_for code, i think that's probably it. See this change: #8923

[jywarren]

I'll try reverting that change in local and checking the generated url of the form in HTML...

[jywarren]

OK, current form shows <form action="/features/11796" accept-charset="UTF-8" method="post">

let me see after reverting this form_for change...

[jywarren]

Hmm. Reverting :node to @node makes it <form class="edit_drupal_node" id="edit_drupal_node" action="/features/44" accept-charset="UTF-8" method="post">

looks pretty similar... let me inspect the whole form, maybe even try submitting it and inspecting the package sent...

[daemon1024]

-<%= form_for :node, :as => :drupal_node, :url => url do |f| %>
+<%= form_for @node, :as => :drupal_node, :url => url do |f| %>

This solved it :)

[daemon1024]

@node was changed to :node unknowingly i guess.

[daemon1024]

Hmm. Reverting :node to @node makes it <form class="edit_drupal_node" id="edit_drupal_node" action="/features/44" accept-charset="UTF-8" method="post">

looks pretty similar... let me inspect the whole form, maybe even try submitting it and inspecting the package sent...

Ohh I missed this.

[jywarren]

Agreed. I'm going to try triggering a validation error to see if the displayed messages still work, as that was the target of the fix.

[jywarren]

Looks ok!

I guess maybe it was a mistaken or unrelated change?

I'll rush this into production but we should back it with an integration test. That could be a pretty good FTO!

[daemon1024]

🎉

[jywarren]

99e0157 and monitoring the tests before merging to stable and publishing!

[jywarren]

Thank you so much, @daemon1024 !!!