Refactor old error_messages usage and added errorMessage partial

[Manasa2850]

Fixes #8937 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gitpod-io]

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@7a40239). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8923   +/-   ##
=======================================
  Coverage        ?   81.87%           
=======================================
  Files           ?      100           
  Lines           ?     5943           
  Branches        ?        0           
=======================================
  Hits            ?     4866           
  Misses          ?     1077           
  Partials        ?        0           

[Manasa2850]

@jywarren @cesswairimu could you please review this? If this PR is fine, I'll create first timer issues for the rest of the files to use the partial. Thanks in advance!

[codeclimate]

Code Climate has analyzed commit c7bf0f1 and detected 0 issues on this pull request.

View more on Code Climate.

[Uzay-G]

This seems good. Could you maybe take a screenshot of the error messages rendering correctly?

[cesswairimu]

Hey @Manasa2850 thanks a lot for opening this...love the error partial, we could refactor all the other views after this is merged. I would like to pint out that we are planning to remove the dynamic gem and that is already done here #4575, you could merge this branch with yours and then we can start from there...what do you think?

[cesswairimu]

there are also a few files left, would you like to change those ones too? Its also okay if you would like to handle only the features templates and I can create a breakout issue for that alone and you wouldn't need to worry about the PR I mentioned above...its totally up to you let me know what you feel would be best for you. Thanks again

[Manasa2850]

Hi @cesswairimu I thought of creating first timer issues for the refactoring in the remaining files. So I think we'll be able to remove the dynamic gem only after changes have been made in all those files.

[cesswairimu]

Great, sounds good, let me create a issue we can link to this and have it merged..looks good from gitpod thanks

[cesswairimu]

@Manasa2850 when you do create the ftos kindly link them to the main issue for organization. thanks @Uzay-G for the review 🎉

[Manasa2850]

Sure I'll do that @cesswairimu. Thank you!