Import French translations from Transifex (template issue for copying) #9481

jywarren · 2021-04-09T14:59:08Z

@ebarry notes that a French translation team has been working on translations for a year (!! wow awesome!) and we'd like to import these. (cc lead French translator @XavCC)

I wanted to note steps here so we do this with good coordination:

check what's ready to be imported (do they need reviews?)
check what would be imported (i'm not sure we can do /only/ french translations so this might involve importing all new strings, which is OK too, just good to be clear about
run the import, generating a new pull request with all the new translations
add the language code (i.e. fr) to this line: https://github.com/publiclab/plots2/blob/main/config/application.rb#L58
merge it!
Check by going to https://publiclab.org/change_locale/fr
add new languages to the footer dropdown (via the Features system, so for example https://publiclab.org/change_locale/hi-IN for Hindi.)

We can run through part of this checklist each time we do it.

The text was updated successfully, but these errors were encountered:

for #9481 (this is ALL french strings, not just reviewed ones)

XavCC · 2021-04-09T15:04:51Z

I could spend a few hours this weekend reviewing translated strings.

jywarren · 2021-04-09T15:06:46Z

Hi, @XavCC !! Awesome to hear from you and thank you for all the excellent work!

Just an update from our dashboard, French is 100% translated, but about 15% reviewed, but marked "ready to use":

So, we can download either ALL the french translations OR just those that are reviewed:

I wanted to see if we could get input from the reviewers team on whether to import all or just reviewed? Either seems pretty easy!

Also i see @XavCC, OscarTrente and jibe_b are reviewers but only @XavCC seems to have a github account under that name. Happy to hear from other reviewers if that's helpful!

jywarren · 2021-04-09T15:13:28Z

Note /all/ translations are available in #9482 now, so if we don't want to review first, we can just merge this and do reviews in a later import! Thanks!

jywarren · 2021-04-09T15:15:32Z

Interesting that we can do this in an automated way from the settings/integration dialog:

This can be part of a new documentation of how to run imports, on https://publiclab.org/wiki/translation

govindgoel · 2021-04-09T15:35:18Z

@jywarren This is really awesome and now we can do it in an automated way too.

jywarren · 2021-04-13T18:58:19Z

OK, we'll go ahead and merge the French set for now and we can make modifications later if folks want to review more! Thank you!!!

for #9481 (this is ALL french strings, not just reviewed ones)

jywarren · 2021-04-13T19:57:07Z

Noting a missing step - i found we need to add the language code fr to this line:

plots2/config/application.rb

Line 58 in 8c729b2

    
           I18n.available_locales = [:en, :de, "zh-CN", :ar, :es, "hi-IN", :it, :ko, "pt-BR", :ru]

jywarren · 2021-04-13T20:18:24Z

That worked! It should publish this coming weekend to the live site:

jywarren · 2021-04-13T21:30:47Z

Reopening as we got an error in integration tests prob from the config change...

Reverting in #9504

https://github.com/publiclab/plots2/pull/9504/checks?check_run_id=2337234225#step:7:144

Minitest::UnexpectedError:         ActionView::Template::Error: missing interpolation argument :search in "Aucun résultat trouvé en cherchant \"%{search}\"" ({:tag=>"some-tag"} given)
            app/helpers/application_helper.rb:158:in `translation'
            app/views/tag/widget.html.erb:14:in `_app_views_tag_widget_html_erb__3684193017882036563_47228995284600'
            app/controllers/tag_controller.rb:250:in `widget'
            test/integration/I18n_test.rb:425:in `block (2 levels) in <class:I18nTest>'
            test/integration/I18n_test.rb:421:in `each'
            test/integration/I18n_test.rb:421:in `block in <class:I18nTest>'

== FAIL I18nTest#test_should_choose_i18n_for_user/_form_+_user/new (224.46s)
        <Nom d'utilisateur·ice> expected but was
        <Nom d'utilisat⋅eur·ice>..
        Expected 0 to be >= 1.
        test/integration/I18n_test.rb:198:in `block (2 levels) in <class:I18nTest>'
        test/integration/I18n_test.rb:194:in `each'
        test/integration/I18n_test.rb:194:in `block in <class:I18nTest>'

) * move csrf token into formdata for PublicLab.Editor richTextModule ref #9438 * remove ", :fr" from application.rb re #9481

XavCC · 2021-04-18T10:09:40Z

Hi,

I will correct this mistake in transiflex today

[…]
== FAIL I18nTest#test_should_choose_i18n_for_user/_form_+_user/new (224.46s)
        <Nom d'utilisateur·ice> expected but was
        <Nom d'utilisat⋅eur·ice>..
        Expected 0 to be >= 1.
        test/integration/I18n_test.rb:198:in `block (2 levels) in <class:I18nTest>'
        test/integration/I18n_test.rb:194:in `each'
        test/integration/I18n_test.rb:194:in `block in <class:I18nTest>'

Edit:

Done at 12:50 pm CET

Building on #9481 and #9504!

jywarren · 2021-05-11T20:26:53Z

Working on this in #9619! Next week i hope! 😅

jywarren · 2021-05-18T21:44:36Z

Noting we had some translation strings change, and the parameter name changed too, and there might be some things to watch out for in future attempts around parameters. Notes in #9619 (comment). Hopefully it works now 🤞

* 2nd attempt to add French translations Building on #9481 and #9504! * Update and rename for_use_publiclaborg_en-yml--master_fr.yml to fr.yml * swap \" for ' * change "search" param to "tag"

jywarren · 2021-05-20T15:42:39Z

This is working! Great work, folks. This can now be used as a template for other language imports.

jywarren · 2021-05-20T15:44:11Z

Thanks @XavCC for your work on this!

jywarren · 2021-05-20T15:44:37Z

cc @imajit this is really promising for the upcoming workflows we're imagining. Take a look!

Tlazypanda · 2021-10-03T19:45:06Z

Hey @DalilaBA Looping you here to reach out to @XavCC for any queries you may have 😅 I am not that familiar with the transifex translation procedure so hoping this leads to some clarity ✌️

DalilaBA · 2021-10-03T19:51:31Z

Alright thank you ☺️

for publiclab#9481 (this is ALL french strings, not just reviewed ones)

fixes publiclab#9481

…bliclab#9504) * move csrf token into formdata for PublicLab.Editor richTextModule ref publiclab#9438 * remove ", :fr" from application.rb re publiclab#9481

* 2nd attempt to add French translations Building on publiclab#9481 and publiclab#9504! * Update and rename for_use_publiclaborg_en-yml--master_fr.yml to fr.yml * swap \" for ' * change "search" param to "tag"

XavCC · 2021-11-05T12:18:12Z

Hi,

Welcome @DalilaBA !

on the actual published version of the website, I tested french version.

I tried with disabled No-Script and Umatrix add-on, it works but only some few words appeared in french even only 6 words aren't translated in transiflex for french version.

For @jywarren and al.

Mozilla Firefox 92.0
Arch Linux x86_64
Javascript activated (just for PublicLab website)
WebGL activated  (just for PublicLab website)

By the way, I reviewed some translated strings today in transiflex french version. We reached 84% reviewed strings.

Also, I "called my twitter followers" to test french version and to send feedback

Hope reading or hearing you soon,

Take care!

DalilaBA · 2021-11-05T12:46:37Z

hi @XavCC thank you 😄
I'm really new with the Transifex and the synchronization with the local files.
I just checked the fr.yml file for the ( layout._header.community.community_title) key and it is not there, even that it is in the en.yml and translated and verified in the Transifex.
So I might think that the problem is at the synchronisation, I don't really now what to do further then that, I hope it helped

for publiclab#9481 (this is ALL french strings, not just reviewed ones)

fixes publiclab#9481

…bliclab#9504) * move csrf token into formdata for PublicLab.Editor richTextModule ref publiclab#9438 * remove ", :fr" from application.rb re publiclab#9481

* 2nd attempt to add French translations Building on publiclab#9481 and publiclab#9504! * Update and rename for_use_publiclaborg_en-yml--master_fr.yml to fr.yml * swap \" for ' * change "search" param to "tag"

jywarren added the Translation System issues which involve adding new translations, improving the translation system label Apr 9, 2021

jywarren added a commit that referenced this issue Apr 9, 2021

Add french translations from Transifex

7f436b6

for #9481 (this is ALL french strings, not just reviewed ones)

jywarren mentioned this issue Apr 9, 2021

Add french translations from Transifex #9482

Merged

jywarren mentioned this issue Apr 9, 2021

Discussion and Q&A of Outreachy + GSoC ideas 2021 #9257

Closed

jywarren added a commit that referenced this issue Apr 13, 2021

Add french translations from Transifex (#9482)

8c729b2

for #9481 (this is ALL french strings, not just reviewed ones)

jywarren closed this as completed in 6168103 Apr 13, 2021

jywarren reopened this Apr 13, 2021

jywarren added a commit that referenced this issue Apr 13, 2021

remove ", :fr" from application.rb re #9481

7b8e4f8

jywarren added a commit that referenced this issue Apr 13, 2021

move csrf token into formdata for PublicLab.Editor richTextModule (#9504

1a6ae29

) * move csrf token into formdata for PublicLab.Editor richTextModule ref #9438 * remove ", :fr" from application.rb re #9481

jywarren added a commit that referenced this issue May 11, 2021

2nd attempt to add French translations

d7c3186

Building on #9481 and #9504!

jywarren mentioned this issue May 11, 2021

2nd attempt to add French translations #9619

Merged

jywarren changed the title ~~Import French translations from Transifex~~ Import French translations from Transifex (template issue for copying) May 20, 2021

jywarren mentioned this issue Jun 29, 2021

[Discusssion] Import translated strings from Transifex #9859

Closed

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021

Add french translations from Transifex (publiclab#9482)

ac0cfa9

for publiclab#9481 (this is ALL french strings, not just reviewed ones)

reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021

add french "fr" to I18n.available_locales

649f034

fixes publiclab#9481

billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021

Add french translations from Transifex (publiclab#9482)

b37d7a3

for publiclab#9481 (this is ALL french strings, not just reviewed ones)

billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021

add french "fr" to I18n.available_locales

f73e600

fixes publiclab#9481

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import French translations from Transifex (template issue for copying) #9481

Import French translations from Transifex (template issue for copying) #9481

jywarren commented Apr 9, 2021 •

edited

Loading

XavCC commented Apr 9, 2021

jywarren commented Apr 9, 2021

jywarren commented Apr 9, 2021

jywarren commented Apr 9, 2021

govindgoel commented Apr 9, 2021

jywarren commented Apr 13, 2021

jywarren commented Apr 13, 2021

jywarren commented Apr 13, 2021

jywarren commented Apr 13, 2021

XavCC commented Apr 18, 2021 •

edited

Loading

jywarren commented May 11, 2021

jywarren commented May 18, 2021

jywarren commented May 20, 2021

jywarren commented May 20, 2021

jywarren commented May 20, 2021

Tlazypanda commented Oct 3, 2021

DalilaBA commented Oct 3, 2021

XavCC commented Nov 5, 2021 •

edited

Loading

DalilaBA commented Nov 5, 2021 •

edited

Loading

Import French translations from Transifex (template issue for copying) #9481

Import French translations from Transifex (template issue for copying) #9481

Comments

jywarren commented Apr 9, 2021 • edited Loading

XavCC commented Apr 9, 2021

jywarren commented Apr 9, 2021

jywarren commented Apr 9, 2021

jywarren commented Apr 9, 2021

govindgoel commented Apr 9, 2021

jywarren commented Apr 13, 2021

jywarren commented Apr 13, 2021

jywarren commented Apr 13, 2021

jywarren commented Apr 13, 2021

XavCC commented Apr 18, 2021 • edited Loading

jywarren commented May 11, 2021

jywarren commented May 18, 2021

jywarren commented May 20, 2021

jywarren commented May 20, 2021

jywarren commented May 20, 2021

Tlazypanda commented Oct 3, 2021

DalilaBA commented Oct 3, 2021

XavCC commented Nov 5, 2021 • edited Loading

DalilaBA commented Nov 5, 2021 • edited Loading

jywarren commented Apr 9, 2021 •

edited

Loading

XavCC commented Apr 18, 2021 •

edited

Loading

XavCC commented Nov 5, 2021 •

edited

Loading

DalilaBA commented Nov 5, 2021 •

edited

Loading