-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add diher.solutions and rss.my.id to the list #1393
Conversation
add new public suffix for Diher Solutions
Made some suggestions about the contributor guidelines and ordering of the submitted PR. Needs updating to meet the guidelines. Also: The AOL email address bounced as undeliverable on the contact in the header. Is there an alternative company / submitter name that could be used that has better reachability? |
do i need to open whois privacy ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no comment on whois privacy. my comment was that there was an attempt to email that listed contact which was not possible. That's not wise to have at the onset, especially when there seems to be so much iteration required to be involved, and the recommendations had been articulated in the bounced email. We definitely require a valid email address to be present, so perhaps consider a reachable replacement for the AOL address as you're making these other changes.
Two changes below. If we start to have further challenges in getting this filled out correctly, it may be time to request you get help from someone on filling this out.
that's good. i have fixed it. thank you for guiding me. please check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- DNS Validation ok
- Tests ok
- Rationale ok
- No conflict with base
- Formatted / Sorted per Guidelines
Approved
Thank you for remedying the sorting. Merging. I see above where you acknowledged reading the understanding and acceptance of propogation. You are affecting your core URL for diher.solutions, so ... good luck. |
@dnsguru Does it make sense to be adding both *.diher.solutions and diher.solutions to the list? At least for Mozilla, this is breaking when we try to update PSL data for Firefox due to repeating domain name errors. Same for rss.my.id. |
@rvandermeulen Yeah, that will also break Chrome. Our linter was supposed to catch this - https://github.com/publicsuffix/list/blob/master/linter/test_duplicate.input We had the linter wired up to Travis in e6065d2#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485 (and refactored subsequently into the Makefile), but we never wired that up for GitHub Actions, and the whole Travis kerfuffle has meant we've lost testing coverage. Any chance you'd be willing to fiddle with GitHub Actions to get it running our lints again? I'm not sure I'll be able to get to it in the next week, but that would help prevent this for both you (and us/Chrome) |
Interesting ... we need to require binary choice between the two for this.
Needs a rollback pr I will do now
…On Thu, Sep 2, 2021, 6:26 AM Ryan VanderMeulen ***@***.***> wrote:
@dnsguru <https://github.com/dnsguru> Does it make sense to be adding
both *.diher.solutions and diher.solutions to the list? At least for
Mozilla, this is breaking when we try to update PSL data for Firefox due to
repeating domain name errors.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1393 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQTJNZDKLNBTNT6YV2OULT753OTANCNFSM5BWR2OJA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Yeah, that's captured in #694 (comment) |
foo.bar and *.foo.bar can't both be added, and I let #1393 through, where the linter typically catches and fails them. @pereceh you must re-sumbit and choose only one of each, please reference #1393 in the new PR // Diher Solutions : https://diher.solutions // Submitted by Didi Hermawan <mail@diher.solutions> rss.my.id *.rss.my.id diher.solutions *.diher.solutions
* Roll back diher.solutions PR #1393 foo.bar and *.foo.bar can't both be added, and I let #1393 through, where the linter typically catches and fails them. @pereceh you must re-sumbit and choose only one of each, please reference #1393 in the new PR // Diher Solutions : https://diher.solutions // Submitted by Didi Hermawan <mail@diher.solutions> rss.my.id *.rss.my.id diher.solutions *.diher.solutions * Pull out rss.id.my and diher.solutions
add a new public suffix for Diher Solutions to use by yourself. everyone can use the domains I added for informational purposes.
Description of Organization
Reason for PSL Inclusion
DNS verification via dig
Run Syntax Checker (make test)
Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place
Submitter affirms the following:
For Private section requests that are submitting entries for domains that match their organization website's primary domain:
(Link: about propogation/expectations)
Description of Organization
Organization Website: https://rss.my.id
I am a blog writer. and I'm also the sole manager for the listed domains.
Reason for PSL Inclusion
I'm planning to automate the provision of a destination subdomain in place of an address on a web hosting server. my purpose of implementing this is for Cookie Security, as different customers will have control over the subdomain.
The rss.my.id domain is on a 3-year renewal and currently registered until 2024-07-24,
and diher.solutions domain is on a 9-year renewal and currently registered until 2031-03-15.
DNS Verification via dig
make test
All tests passed.