Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add diher.solutions and rss.my.id to the list #1393

Merged
merged 7 commits into from
Sep 1, 2021

Conversation

pereceh
Copy link
Contributor

@pereceh pereceh commented Aug 6, 2021

add a new public suffix for Diher Solutions to use by yourself. everyone can use the domains I added for informational purposes.

  • Description of Organization

  • Reason for PSL Inclusion

  • DNS verification via dig

  • Run Syntax Checker (make test)

  • Each domain listed in the PRIVATE section has and shall maintain at least two years remaining on registration, and we shall keep the _PSL txt record in place

Submitter affirms the following:

  • We are listing any third party limits that we seek to work around in our rationale such as those between IOS 14.5+ and Facebook (see Issue #1245 as a well-documented example)
  • This request was not submitted with the objective of working around other third party limits
  • The Guidelines were carefully read and understood, and this request conforms
  • The submission follows the guidelines on formatting

For Private section requests that are submitting entries for domains that match their organization website's primary domain:

Seriously, carefully read the downline flow of the PSL and the guidelines.
Your request could very likely alter the cookie and certificate (as well as other) behaviours on your 
core domain name in ways that could be problematic for your business.

Rollback is really not predicatable, as those who use or incorporate the PSL do what they do, and when.
It is not within the PSL volunteers' control to do anything about that.  

The volunteers are busy with new requests, and rollbacks are lowest priority, so if something gets broken 
it will stay that way for an indefinitely long while.

(Link: about propogation/expectations)

  • Yes, I understand. I could break my organization's website cookies etc. and the rollback timing, etc is acceptable. Proceed.

Description of Organization

Organization Website: https://rss.my.id

I am a blog writer. and I'm also the sole manager for the listed domains.

Reason for PSL Inclusion

I'm planning to automate the provision of a destination subdomain in place of an address on a web hosting server. my purpose of implementing this is for Cookie Security, as different customers will have control over the subdomain.

The rss.my.id domain is on a 3-year renewal and currently registered until 2024-07-24,

and diher.solutions domain is on a 9-year renewal and currently registered until 2031-03-15.

DNS Verification via dig

dig +short TXT _psl.diher.solutions
"https://github.com/publicsuffix/list/pull/1393"
dig +short TXT _psl.rss.my.id
"https://github.com/publicsuffix/list/pull/1393"

make test

All tests passed.

add new public suffix for Diher Solutions
@pereceh pereceh changed the title Update public_suffix_list.dat add diher.solutions and rss.my.id to the list Aug 7, 2021
public_suffix_list.dat Outdated Show resolved Hide resolved
public_suffix_list.dat Outdated Show resolved Hide resolved
@dnsguru dnsguru added the waiting-followup Blocked for need of follow-up label Aug 12, 2021
@dnsguru
Copy link
Member

dnsguru commented Aug 12, 2021

Made some suggestions about the contributor guidelines and ordering of the submitted PR. Needs updating to meet the guidelines.

Also: The AOL email address bounced as undeliverable on the contact in the header. Is there an alternative company / submitter name that could be used that has better reachability?

@pereceh
Copy link
Contributor Author

pereceh commented Aug 12, 2021

Made some suggestions about the contributor guidelines and ordering of the submitted PR. Needs updating to meet the guidelines.

Also: The AOL email address bounced as undeliverable on the contact in the header. Is there an alternative company / submitter name that could be used that has better reachability?

do i need to open whois privacy ?

Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comment on whois privacy. my comment was that there was an attempt to email that listed contact which was not possible. That's not wise to have at the onset, especially when there seems to be so much iteration required to be involved, and the recommendations had been articulated in the bounced email. We definitely require a valid email address to be present, so perhaps consider a reachable replacement for the AOL address as you're making these other changes.

Two changes below. If we start to have further challenges in getting this filled out correctly, it may be time to request you get help from someone on filling this out.

public_suffix_list.dat Outdated Show resolved Hide resolved
public_suffix_list.dat Show resolved Hide resolved
@pereceh
Copy link
Contributor Author

pereceh commented Aug 12, 2021

no comment on whois privacy. my comment was that there was an attempt to email that listed contact which was not possible. That's not wise to have at the onset, especially when there seems to be so much iteration required to be involved, and the recommendations had been articulated in the bounced email. We definitely require a valid email address to be present, so perhaps consider a reachable replacement for the AOL address as you're making these other changes.

Two changes below. If we start to have further challenges in getting this filled out correctly, it may be time to request you get help from someone on filling this out.

that's good. i have fixed it. thank you for guiding me. please check again.

@pereceh pereceh requested a review from dnsguru August 12, 2021 20:21
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • DNS Validation ok
  • Tests ok
  • Rationale ok
  • No conflict with base
  • Formatted / Sorted per Guidelines

Approved

@dnsguru
Copy link
Member

dnsguru commented Sep 1, 2021

Thank you for remedying the sorting. Merging. I see above where you acknowledged reading the understanding and acceptance of propogation. You are affecting your core URL for diher.solutions, so ... good luck.

@dnsguru dnsguru merged commit 57c293c into publicsuffix:master Sep 1, 2021
@dnsguru dnsguru removed the waiting-followup Blocked for need of follow-up label Sep 1, 2021
@dnsguru dnsguru self-assigned this Sep 1, 2021
@dnsguru dnsguru added the NOT IOS FB Submitter attests PR is not #1245 related label Sep 1, 2021
@rvandermeulen
Copy link
Contributor

rvandermeulen commented Sep 2, 2021

@dnsguru Does it make sense to be adding both *.diher.solutions and diher.solutions to the list? At least for Mozilla, this is breaking when we try to update PSL data for Firefox due to repeating domain name errors. Same for rss.my.id.

@sleevi
Copy link
Contributor

sleevi commented Sep 2, 2021

@rvandermeulen Yeah, that will also break Chrome.

Our linter was supposed to catch this - https://github.com/publicsuffix/list/blob/master/linter/test_duplicate.input

We had the linter wired up to Travis in e6065d2#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485 (and refactored subsequently into the Makefile), but we never wired that up for GitHub Actions, and the whole Travis kerfuffle has meant we've lost testing coverage.

Any chance you'd be willing to fiddle with GitHub Actions to get it running our lints again? I'm not sure I'll be able to get to it in the next week, but that would help prevent this for both you (and us/Chrome)

@dnsguru
Copy link
Member

dnsguru commented Sep 2, 2021 via email

@sleevi
Copy link
Contributor

sleevi commented Sep 2, 2021

Yeah, that's captured in #694 (comment)

dnsguru added a commit that referenced this pull request Sep 2, 2021
foo.bar and *.foo.bar can't both be added, and I let #1393 through, where the linter typically catches and fails them.
@pereceh you must re-sumbit and choose only one of each, please reference #1393 in the new PR

// Diher Solutions : https://diher.solutions
// Submitted by Didi Hermawan <mail@diher.solutions>
rss.my.id
*.rss.my.id
diher.solutions
*.diher.solutions
@dnsguru
Copy link
Member

dnsguru commented Sep 2, 2021

@sleevi can you review #1406

dnsguru added a commit that referenced this pull request Sep 2, 2021
* Roll back diher.solutions PR #1393

foo.bar and *.foo.bar can't both be added, and I let #1393 through, where the linter typically catches and fails them.
@pereceh you must re-sumbit and choose only one of each, please reference #1393 in the new PR

// Diher Solutions : https://diher.solutions
// Submitted by Didi Hermawan <mail@diher.solutions>
rss.my.id
*.rss.my.id
diher.solutions
*.diher.solutions

* Pull out rss.id.my and diher.solutions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NOT IOS FB Submitter attests PR is not #1245 related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants