Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rss.my.id and diher.solutions #1415

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Update rss.my.id and diher.solutions #1415

merged 1 commit into from
Sep 10, 2021

Conversation

pereceh
Copy link
Contributor

@pereceh pereceh commented Sep 10, 2021

As per reference #1406 , i want to remove wildcard characters for rss.my.id and diher.solutions to make them look better. I also used the previous _psl txt record #1393 .

Removed the wildcard characters for rss.my.id and diher.solutions to make them look better.
Copy link
Member

@dnsguru dnsguru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix; Previously vetted
APPROVED

@dnsguru dnsguru merged commit 9ab0f23 into publicsuffix:dnsguru-pick-one-cant-have-both Sep 10, 2021
@dnsguru
Copy link
Member

dnsguru commented Sep 10, 2021

@pereceh I rushed this one through - I see that the timing of when I modified / merged the last one with the change and when your message clarifying which to keep of the two conflicting (*. and not) entries per name in the thread happened right at around the same time and we got our wires crossed.

@dnsguru dnsguru self-assigned this Sep 10, 2021
@dnsguru dnsguru added r=dnsguru Marked as approved and ready to merge by @dnsguru 😭rollback Requestor seeking to remove or revise an entry labels Sep 10, 2021
@pereceh
Copy link
Contributor Author

pereceh commented Sep 10, 2021

@pereceh I rushed this one through - I see that the timing of when I modified / merged the last one with the change and when your message clarifying which to keep of the two conflicting (*. and not) entries per name in the thread happened right at around the same time and we got our wires crossed.

wow looks like a mistake i modified the branch... i want it without the wildcard (*). so the master branch should be:
rss.my.id
diher.solutions

please help apply this patch to master branch @dnsguru .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r=dnsguru Marked as approved and ready to merge by @dnsguru 😭rollback Requestor seeking to remove or revise an entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants