Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test remaining 008 types for bad_008? and the fixes #75

Closed
4 tasks done
mzelesky opened this issue Dec 1, 2023 · 2 comments
Closed
4 tasks done

Test remaining 008 types for bad_008? and the fixes #75

mzelesky opened this issue Dec 1, 2023 · 2 comments
Assignees
@Beck-Davis
Labels
test For adding fixtures and spec tests

Comments

@mzelesky
Copy link
Member

mzelesky commented Dec 1, 2023 •
edited by Beck-Davis
Loading

2 types of 008 have already been tested: books and computer files. However, only the error identification has been tested. All 008 types need to be tested.

Acceptance criteria:

  • Each type of 008 needs to be tested under bad_008?
  • Each type of 008 needs to be tested under fix_008
  • An 008 with a field length other than 40 characters is tested
  • bad_008_spec.rb should be renamed 008_spec.rb
@mzelesky mzelesky added the test For adding fixtures and spec tests label Dec 1, 2023
@mzelesky mzelesky assigned mzelesky and Beck-Davis and unassigned mzelesky Dec 1, 2023
Beck-Davis added a commit that referenced this issue Dec 13, 2023
@Beck-Davis
Rename bad_008_spec.rb to 008_spec.rb
8df8478 
Changing file name from `bad_008_spec.rb` to `008_spec.rb` per issue #75.
@Beck-Davis Beck-Davis mentioned this issue Dec 13, 2023
Merged
mzelesky pushed a commit that referenced this issue Dec 13, 2023
@Beck-Davis
Rename bad_008_spec.rb to 008_spec.rb (#82)
c544c8e 
Changing file name from `bad_008_spec.rb` to `008_spec.rb` per issue #75.
@pmgreen
Copy link
Contributor

pmgreen commented Dec 19, 2023

Moved this ticket from new issues to sprint backlog because @Beck-Davis is actively working on it.

@pmgreen
Copy link
Contributor

pmgreen commented Dec 19, 2023

Reviewed and merged #84

@pmgreen pmgreen closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Beck-Davis Beck-Davis

Labels
test For adding fixtures and spec tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pmgreen @mzelesky @Beck-Davis