Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional spec tests for fix_008 #84

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Additional spec tests for fix_008 #84

merged 7 commits into from
Dec 19, 2023

Conversation

Beck-Davis
Copy link
Contributor

@Beck-Davis Beck-Davis commented Dec 15, 2023 •
edited
Loading

Additional spec tests for fix_008 methods added to '008_spec.rb'

@Beck-Davis Beck-Davis marked this pull request as draft December 15, 2023 14:58
@Beck-Davis Beck-Davis marked this pull request as ready for review December 19, 2023 14:32
@Beck-Davis Beck-Davis requested a review from pmgreen December 19, 2023 14:33
@Beck-Davis Beck-Davis changed the title Draft: Additional spec tests for fix_008 Additional spec tests for fix_008 Dec 19, 2023
pmgreen
pmgreen approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@pmgreen pmgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scanned the code, checked out this branch and ran the tests: 16 examples, 0 failures

@pmgreen pmgreen merged commit 9aea23c into main Dec 19, 2023
2 checks passed
@pmgreen pmgreen deleted the issue75_fix008 branch December 19, 2023 21:48
@pmgreen pmgreen mentioned this pull request Dec 19, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmgreen pmgreen pmgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Beck-Davis @pmgreen