Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show file download table when there are no files #229

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

bess
Copy link
Contributor

@bess bess commented Mar 15, 2022

But still display the Globus download button if globus downloads are
possible.

Fixes #220

Screen Shot 2022-03-15 at 4 51 51 PM

Copy link
Contributor

@jrgriffiniii jrgriffiniii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two minor failures with RuboCop, but this otherwise seems like an excellent improvement to me. Thank you very much @bess !

But still display the Globus download button if globus downloads are
possible.
@bess bess force-pushed the i220-object-without-files branch from 41cce48 to c19cceb Compare March 15, 2022 20:58
@bess bess merged commit 34b71af into main Mar 15, 2022
@bess bess deleted the i220-object-without-files branch March 15, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display of item with no files
2 participants