-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AXI4 on chip memory slave #213
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
891e99d
to
918a19f
Compare
Thanks for the effort of updating this code and getting it into a PR, @micprog! I highly appreciate it. However, I cannot allocate a block of time to review more than 2k LoC. Please split this into multiple PRs. For instance, the first PR should simply add the latest version of |
This was referenced Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of the relevant changes in #115 on the current master
This adds two modules:
axi_to_mem
: Slave module, max throughout simultaneous read/writes 50%, read or write 100%.axi_to_mem_banked
: With enough banks 100% throughput with simultaneous reads/writes.Notes to Bender:
For the dependencies pulp-platform/tech_cells_generic has been directly added. In there the tc_sram module is used for the testbench to serve a memory model.
Open tasks
mem_to_banks
to ensure no writes are issued withstrb='0
. While not illegal, this can cause issues (e.g. when converting back to APB3) and unnecessary contention on an interconnect