Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AXI4 on chip memory slave #213

Closed
wants to merge 17 commits into from
Closed

AXI4 on chip memory slave #213

wants to merge 17 commits into from

Conversation

micprog
Copy link
Member

@micprog micprog commented Feb 25, 2022

Rebase of the relevant changes in #115 on the current master

This adds two modules:

  • axi_to_mem: Slave module, max throughout simultaneous read/writes 50%, read or write 100%.
  • axi_to_mem_banked: With enough banks 100% throughput with simultaneous reads/writes.

Notes to Bender:
For the dependencies pulp-platform/tech_cells_generic has been directly added. In there the tc_sram module is used for the testbench to serve a memory model.

Open tasks

  • Rework mem_to_banks to ensure no writes are issued with strb='0. While not illegal, this can cause issues (e.g. when converting back to APB3) and unnecessary contention on an interconnect
  • Add an interleaved variant to allow reads and writes to bypass each other
  • Add a split variant to completely separate the read and write channel to individual mem ports when connecting to an interconnect

@micprog micprog force-pushed the axi_to_mem_rebase branch from 891e99d to 918a19f Compare August 5, 2022 15:26
@micprog micprog marked this pull request as ready for review August 5, 2022 15:27
@andreaskurth
Copy link
Contributor

Thanks for the effort of updating this code and getting it into a PR, @micprog! I highly appreciate it.

However, I cannot allocate a block of time to review more than 2k LoC. Please split this into multiple PRs. For instance, the first PR should simply add the latest version of axi_to_mem.

@micprog
Copy link
Member Author

micprog commented Aug 30, 2022

Merged with #244 and #248 and #256

@micprog micprog closed this Aug 30, 2022
@thommythomaso
Copy link
Collaborator

@thommythomaso thommythomaso deleted the axi_to_mem_rebase branch September 28, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants