Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent naming of "settings" #293

Closed
evgeni opened this issue Jul 2, 2021 · 2 comments · Fixed by #307
Closed

inconsistent naming of "settings" #293

evgeni opened this issue Jul 2, 2021 · 2 comments · Fixed by #307
Labels
feature request New feature request (template-set)
Milestone
0.11.0

Comments

@evgeni
Copy link
Member

evgeni commented Jul 2, 2021 

# pulp config create
Created config file at '/root/.config/pulp/settings.toml'.

the cli param is config but the file is called settings? ;-)
@mdellweg
Copy link
Member

mdellweg commented Jul 2, 2021

😢 yes.

@mdellweg mdellweg mentioned this issue Jul 2, 2021
Closed
@ggainey ggainey added feature request New feature request (template-set) triaged labels Jul 7, 2021
@ggainey
Copy link
Contributor

ggainey commented Jul 7, 2021

If we decide to do this - we should respect both the old- and the new-name, maybe w/a deprecation warning?

mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jul 16, 2021
@mdellweg
Add a global config file, rename the user config
d383e3d 
This will read the global (/etc/pulp/cli_config.toml) first and merge
with the user local ones (settings.toml, cli_config.toml) in that order.
Creating and editing config files default to cli_config now.

fixes pulp#290
fixes pulp#293
@mdellweg mdellweg mentioned this issue Jul 16, 2021
Merged
@mdellweg mdellweg added this to the 0.11.0 milestone Jul 16, 2021
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jul 16, 2021
@mdellweg
Add a global config file, rename the user config
2edc4cb 
This will read the global (/etc/pulp/cli_config.toml) first and merge
with the user local ones (settings.toml, cli_config.toml) in that order.
Creating and editing config files default to cli_config now.

fixes pulp#290
fixes pulp#293
mdellweg added a commit to mdellweg/pulp-cli that referenced this issue Jul 16, 2021
@mdellweg
Add a global config file, rename the user config
9b72266 
This will read the global (/etc/pulp/cli_config.toml) first and merge
with the user local ones (settings.toml, cli_config.toml) in that order.
Creating and editing config files default to cli_config now.

fixes pulp#290
fixes pulp#293
mdellweg added a commit that referenced this issue Jul 16, 2021
@mdellweg
Add a global config file, rename the user config
7dd0877 
This will read the global (/etc/pulp/cli_config.toml) first and merge
with the user local ones (settings.toml, cli_config.toml) in that order.
Creating and editing config files default to cli_config now.

fixes #290
fixes #293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature request (template-set)
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Add a global config file, rename the user config mdellweg/pulp-cli
3 participants
@evgeni @ggainey @mdellweg