Add a global config file, rename the user config #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
refactor_settings
branch
from
d383e3d to
2edc4cb
Compare
|
LGTM. I wonder if we should call this file |
daviddavis
approved these changes
Jul 16, 2021
I always thought Tom's Obvious Minimal Language to play in the json/yaml ballpark, but in any case, the path we are putting the file in gives the conffile character away, too. |
mdellweg
force-pushed
the
refactor_settings
branch
from
2edc4cb to
9b72266
Compare
|
@evgeni do you think, this serves your need? |
|
This reads like what I'd need, yeah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will read the global (/etc/pulp/cli_config.toml) first and merge
with the user local ones (settings.toml, cli_config.toml) in that order.
Creating and editing config files default to cli_config now.
fixes #290
fixes #293