Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push operation does not save config blob with the correct media_type #493

Closed
pulpbot opened this issue Dec 15, 2021 · 3 comments · Fixed by #600
Closed

push operation does not save config blob with the correct media_type #493

pulpbot opened this issue Dec 15, 2021 · 3 comments · Fixed by #600
Assignees
Labels

Comments

@pulpbot
Copy link
Member

pulpbot commented Dec 15, 2021

Author: @ipanova (ipanova@redhat.com)

Redmine Issue: 9229, https://pulp.plan.io/issues/9229


After push operation Config Blob is saved with media_type from a Regular Blob. This issue does not seem to affect pull operation hence priority is not 'everything is on fire ' :)

After podman push :


In [5]: Manifest.objects.first().config_blob.media_type
Out[5]: 'application/vnd.docker.image.rootfs.diff.tar.gzip'

In [6]: Blob.objects.distinct("media_type").values_list('media_type', flat=True)
Out[6]: <QuerySet ['application/vnd.docker.image.rootfs.diff.tar.gzip']>

https://github.com/pulp/pulp_container/blob/master/pulp_container/app/registry_api.py#L685

@pulpbot
Copy link
Member Author

pulpbot commented Dec 15, 2021

From: pulpbot (pulpbot)
Date: 2021-10-08T14:20:44Z


PR: #414

@pulpbot
Copy link
Member Author

pulpbot commented Dec 15, 2021

From: @ipanova (ipanova@redhat.com)
Date: 2021-11-16T12:39:07Z


moving this back to NEW. We might want to deprecate media_type for blob in general, clients do not look at this information at all #414 (comment)

@ipanova
Copy link
Member

ipanova commented Feb 22, 2022

we should not track media_type for the blobs. When registry receives blobs it does not have a way to say what type it is until manifest comes in and after we have parsed it.
Also registry does not gain anything by storing this information.

ipanova added a commit to ipanova/pulp_container that referenced this issue Feb 22, 2022
@ipanova ipanova self-assigned this Feb 22, 2022
ipanova added a commit to ipanova/pulp_container that referenced this issue Feb 22, 2022
lubosmj pushed a commit that referenced this issue Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants