Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't store blob's media_type on the model. #600

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Don't store blob's media_type on the model. #600

merged 1 commit into from
Feb 23, 2022

Conversation

ipanova
Copy link
Member

@ipanova ipanova commented Feb 22, 2022

closes #493

@ipanova ipanova requested review from mdellweg, lubosmj and dkliban and removed request for mdellweg and lubosmj February 22, 2022 15:11
@ipanova
Copy link
Member Author

ipanova commented Feb 22, 2022 •
edited
Loading

@newswangerd, @jlsherrill FYI

@ipanova ipanova requested a review from lubosmj February 22, 2022 15:12
mdellweg
mdellweg approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change. Assuming all the tests still pass.

@newswangerd
Copy link
Contributor

@ipanova We use this data in the automation hub UI to determine if a manifest is a manifest list so we can show the manifest list UI. https://github.com/ansible/ansible-hub-ui/blob/7d7c0379a4b65c623287202d55e91052fc8e3325/src/containers/execution-environment-detail/execution_environment_detail_images.tsx#L562

Is there another way for us to make this determination?

@ipanova
Copy link
Member Author

ipanova commented Feb 22, 2022

@ipanova We use this data in the automation hub UI to determine if a manifest is a manifest list so we can show the manifest list UI. https://github.com/ansible/ansible-hub-ui/blob/7d7c0379a4b65c623287202d55e91052fc8e3325/src/containers/execution-environment-detail/execution_environment_detail_images.tsx#L562

Is there another way for us to make this determination?

@newswangerd this is fine, since the media_type on the manifest model stays. it's removed only from the blob model #493 (comment)

@lubosmj lubosmj merged commit c0500ae into pulp:main Feb 23, 2022
@newswangerd newswangerd mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

@dkliban dkliban Awaiting requested review from dkliban

@lubosmj lubosmj Awaiting requested review from lubosmj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

push operation does not save config blob with the correct media_type
4 participants
@ipanova @newswangerd @mdellweg @lubosmj