This repository has been archived by the owner on May 19, 2023. It is now read-only.
reject promise with Error instance
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sertonix
changed the title
Error instance
Add our Testing Action
|
I've gone ahead and cherry-picked the newer commit containing testing actions to these PR. So we can ensure everything runs as expected. |
confused-Techie
approved these changes
Mar 12, 2023
There was a problem hiding this comment.
Alright all CI is passing here. So lets go ahead and merge this one.
Thanks again @sertonix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the value promises are rejected with from a number to an
Errorinstance. This fixes errors when handling errors and expecting anErrorinstance.