-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle notifications #529
Bundle notifications #529
Conversation
@mauricioszabo Can you do me a favour and add the below text into the body of your PR? It'll make things a whole lot easier when writing the ChangeLog later
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the notification
tests all pass, fully approve.
I've tried this once before and got stumped, so super excited to see it working now!
@confused-Techie Oh.... wait a little bit.... I think I didn't merge the changes from our notification package 🤦 |
Ok, done - authored the only code change on the latest commit /cc @sertonix and @confused-Techie |
Awesome thanks @mauricioszabo Also lets see if this adds it to the PR properly. Resolves #347 |
I forgot to check the files when it was open. My cleanup and rename pull request doesn't seem to be included eather. |
Also, rebrand to Pulsar, and fix quite a lot of issues on opening issue, finding issues on GitHub, etc.
notifications#1 - Cleanup and rename @Sertonix
notifcations#2 - reject promise with Error instance @Sertonix
notifications#3 - Add our Testing Action @confused-Techie
notifications#4 - Change atom strings to pulsar @mdibella-dev
notifications#5 - Bump to v3.2 of action-pulsar-dependency @confused-Techie
notifications#6 - Fix all Tests @confused-Techie