Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught errors still show Atom instead of Pulsar #347

Closed
2 of 5 tasks
wesley5040 opened this issue Jan 26, 2023 · 4 comments · Fixed by #529
Closed
2 of 5 tasks

Uncaught errors still show Atom instead of Pulsar #347

wesley5040 opened this issue Jan 26, 2023 · 4 comments · Fixed by #529
Labels
bug Something isn't working rebrand Related to the rebrand effort

Comments

@wesley5040
Copy link

wesley5040 commented Jan 26, 2023

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

Uncaught error message still shows all Atom branding, and possibly linked to the Atom repo (sorry I didn't think to check, and I've since closed it, if I get a new one I'll update this issue). The thing that caused the error is #134.

error message image

Pulsar version

1.100.0-beta

Which OS does this happen on?

🍎 macOS

OS details

macOS 13

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

Do something that will produce an uncaught error (for we it was a "Cannot decorate a destroyed marker").

Additional Information:

No response

@wesley5040 wesley5040 added the bug Something isn't working label Jan 26, 2023
@confused-Techie confused-Techie added the rebrand Related to the rebrand effort label Jan 26, 2023
mdibella-dev added a commit to mdibella-dev/notifications that referenced this issue Feb 13, 2023
@mdibella-dev
Copy link
Contributor

@wesley5040
Copy link
Author

Turns out the button just does nothing.

@mdibella-dev
Copy link
Contributor

Turns out the button just does nothing.

A fix for this issue is still under review.

@confused-Techie
Copy link
Member

The fix for this issue has now been merged into the notifications repo. All that is left is to go ahead and bundle (or bump) the version used in Pulsar and we can close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rebrand Related to the rebrand effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants