Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ppm to commit 3542dee00f4622f7458f2f65f05e5 #1014

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented May 28, 2024

Includes ppm Pull Requests:

Notes about notable changes:

PR 132 over at the ppm repo in particular is notable, as it fixes an issue with publishing a brand new package with the ppm publish patch command or similar. Other sub-commands of publish to get a brand new package pushed to the Pulsar Package Registry are somewhat more cumbersome or advanced, so this gets the main popular way of publishing a new package "back online," so to speak.

This seems to have also fixed ppm publish --rename, which may have been broken for some time in ppm's master branch? As per my most-recent testing. Seems odd if I didn't recall this being reported before, but that was my impression from researching and testing this fix.

Thanks for @confused-Techie for working through that fix, this has been a while in the making due to being a somewhat puzzling set of issues to debug and troubleshoot under the hood of ppm, also benefiting from knowledge of how the backend itself works.

(Giving myself some credit: I helped test the fixes extensively and gave feedback to develop the approach taken for the fix.)

Thank you also to multiple people for reporting this issue and bringing it to our attention. And, of course, apologies for the disruption to publishing your packages! The fix is here now.

(PR 127 is less notable for end-users, as express is a devDependency only, and would not be expected to be called in "production" or anywhere outside of running ppm's own tests.)

Includes ppm Pull Requests:
- 127 "chore(deps): update dependency express to v4.19.2 [security]"
- 132 "Rewrite publish logic"
@DeeDeeG
Copy link
Member Author

DeeDeeG commented May 29, 2024

See-also: pulsar-edit/ppm#133, which I just posted over at ppm repo.

Perhaps we want to get that shipped with Pulsar soon, if reviewers like that PR to begin with. Just calling it out, as we don't always update ppm in core repo that often (though we easily can). I figured anyone reviewing this PR might want that tidbit of info on their radar.

Best regards.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, could've sworn I merged this a bit ago.

But I'll go ahead and do so now, thanks for getting the update in!

@confused-Techie confused-Techie merged commit 4dd3293 into master Jun 6, 2024
103 checks passed
@DeeDeeG DeeDeeG deleted the update-ppm-late-May-2024 branch August 10, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants