Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were some low-hanging fruit for upgradable dependencies.
(And some slightly higher-hanging fruit, TBH, see the custom resolutions in
package.json
)Might as well, if we can, right?
Tests pass on my machine, and I can still install packages. (I tried
language-carp
andatom-ide-base
; Both had no obvious issues installing, in terms of being able to runppm install language-carp
orppm install atom-ide-base
without running into any errors on the CLI, at least.)Additional manual testing may be desirable, if we can get folks with the knowledge and time to thoroughly do so. Otherwise, we may just have to ask people to test it in the wild if we want to update these deps. In which case, best to have it in Rolling for a while and put out a call for testing there. Otherwise, we can perhaps try to call for testing of
ppm
itself with these changes before shipping it with Pulsar. But in any case, updating these seems like a good idea, IMO.Note: For documentation of Yarn's "resolutions" system, see: https://classic.yarnpkg.com/en/docs/selective-version-resolutions