Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppm: Update ppm to commit d9bcff111146547e1f4dec63 #1075

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Aug 10, 2024

Bumps ppm to a newer copy.

Includes the following ppm pull requests:


As a recap of how to do this:

  • Make sure any commits/PRs you want are merged to the main/default branch of ppm repo (https://github.com/pulsar-edit/ppm).
  • In pulsar core repo's directory, which you should have cloned locally (e.g. by running git clone --recurse-submodules https://github.com/pulsar-edit/pulsar)...
    • Run git submodule update --remote ppm to fetch and check out the latest commits from the ppm repo on GitHub into your local checkout of the ppm submodule in core repo.
    • Run git add ppm to commit the changed ppm submodule SHA to the core repo's record of the submodule.
    • Run git commit to commit the updated submodule in core repo.

In short, that's git clone --recurse-submodules https://github.com/pulsar-edit/pulsar, cd pulsar, git submodule update --remote ppm, git add ppm, and git commit.

Includes the following ppm pull requests:

- 131
- 133
- 134
- 135
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As each of these changes have been tested thoroughly and tests are passing here, I think we are good to merge, lets do it

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Aug 13, 2024

Thanks for review, gonna merge so we have a day or two before release in case anyone is immediately updating their Rolling builds and installing some packages, etc, we can get some early testing in? Slightly/marginally less last-minute?

Anyway, this one's ready and Approved, so I'll merge. Thanks again!

@DeeDeeG DeeDeeG merged commit 025f035 into master Aug 13, 2024
103 checks passed
@savetheclocktower savetheclocktower deleted the update-ppm-again branch September 16, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants