Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ppm to commit 97f4d201be013157756a76008bf0cb55e6a1fe35 #1094

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

savetheclocktower
Copy link
Contributor

PR bumping ppm — following the instructions from #1075.

This has only one change, but it's a major one for Apple Silicon users: native modules should now be built properly for arm64 processors on macOS.

@DeeDeeG
Copy link
Member

DeeDeeG commented Sep 16, 2024

Note: From logging the ppm commits, for example by clicking the comparison link from the "Files changed" tab of this PR (pulsar-edit/ppm@d9bcff1...97f4d20), I can see this bump contains the following ppm PRs:

I probably should have mentioned in the instructions that I usually do check the log and mention the ppm PRs in the core repo "bump ppm" PR, for ease of putting together the changelog later. But now, with this comment, we include the ppm PRs here (for reference when making the changelog for Pulsar 1.121.0).

@savetheclocktower
Copy link
Contributor Author

I think ppm#134 made it into #1075, but I wouldn't bet lots of money on it.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this bump was done correctly, and brings ppm submodule of core repo up to the current tip of ppm repo's master branch (pulsar-edit/ppm@97f4d20).

Also: These changes were planned/expected to be included in core, per discussion among team members in Discord. So, this should be good for inclusion in the upcoming Regular release, IMO.

LGTM!

@DeeDeeG
Copy link
Member

DeeDeeG commented Sep 16, 2024

I think ppm#134 made it into #1075, but I wouldn't bet lots of money on it.

From looking at ppm commit logs, looking closer at the commit ranges given in each each ppm bump PR, I think I inadvertently left pulsar-edit/ppm#134 out of #1075. Despite saying it was included, and intending to include it, in said ppm bump PR (#1075).

Oh well, may as well include it now.

(Stakes are very low; pulsar-edit/ppm#134 is meant to be a code cleanup to do exactly-equivalent code, just with inlined async/await code instead of require()d code from a package. So, the timing of when it lands in core shouldn't be terribly notable, despite it being a good change I was happy to see land in ppm repo itself.)

CONCLUSION: most we need to do about this is maybe restrospectively correct the changelog so pulsar-edit/ppm#134 appears for this Regular release rather than 1.120.0. For accuracy's sake. Not that it is a huge area of end-user concern, hopefully (very low-stakes PR for ppm users IMO).

@savetheclocktower savetheclocktower merged commit 7f04d75 into master Sep 16, 2024
103 checks passed
@savetheclocktower savetheclocktower deleted the bump-ppm-for-1-121 branch September 16, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants