-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config-map failing with "Expected string, but was null" in v4.2 #911
Comments
seems to be related to changes in this PR: #813 |
Hey, thanks for reporting this! It's related to #813; I'll look at a fix very soon! |
I can imagine this was by design, but at least the previous version was more forgiving and many are likely to depend on it. |
I agree, so I'm pushing for a quick release here. My reasoning was that I naively thought the types defined in Automation APIs setAllConfigMap was what users were adhering too. |
For reference, we're seeing the same kinds of errors with In the GHA workflow below,
name: Pulumi Update
on:
push:
branch:
- master
workflow_dispatch:
inputs:
refresh:
description: Should pulumi run refresh?
default: false
required: false
type: boolean
# ...
jobs:
pulumi-update:
steps:
# ...
- name: Run pulumi up
uses: pulumi/actions@v4
id: pulumi-up
with:
refresh: ${{ github.event.inputs.refresh }} Probably I can fix it, but it's a nuisance considering this was a non-major release. |
Haha, it might be a bit far connection for most users :) |
Yeah, I was quite naive 😅 Fix coming up! |
I call it "optimistic" 😉. No worries, thanks for the swift response. |
I hope v4.2.1 fixes the issues! I'm closing this for now, but please let me know if it continues! |
What happened?
Pipeline failures after release of v4.2.
Pipeline code:
Error message
Validation failed: { "prNumber": { "value": "Expected string, but was null" } }. Object should match { [_: string]: { value: string; secret?: boolean; } }
The same happens if
${{ github.event.pull_request.number }}
is provided, but it's a number, the error is then:"Expected string, but was number"
Expected Behavior
No breaking changes in minor release.
Changes in interface communicated in release notes and PR descriptions
Steps to reproduce
See code above
Output of
pulumi about
not essentiral here
Additional context
The issue can be fixed by wrapping params in double quotes or ensuring it's a string.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: