feat: support for config on multiple types on keys and values #912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #813 we naively accepted all kinds of objects into
config-map
, which has led to users having other types than what we have defined in our restrictive runtypes.I think what is described in #911 should be supported, and as @mikocot describes in a comment there are probably a lot of users that depend on that. Since we're currently reflecting the types that are supported by
stack.setAllConfig
from the Automation API, it need to be extended to support more types. IMHO, it should be fine to merge this pull request as a temporary fix (with theas any
hotfix along with a TODO and issue)fixes #911
blocked by pulumi/pulumi#12641