refactor: improve config #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieMcKinstry
approved these changes
Jan 6, 2023
simenandre
force-pushed
the
improve-config
branch
from
69cb8cf
to
908bc7f
Compare
|
it looks like this might have broken passing optional inputs, what was the goal and scope of the refactoring? |
tgummerer
added a commit
that referenced
this pull request
May 24, 2024
…events We only allow the `comment-on-pr` option inside of pull requests. This makes sense because we wouldn't be able to comment on anything otherwise. However with the `comment-on-pr-number` option gives us a PR number to comment on, so it can make sense with any type of GitHub actions event. This used to work before #813, and it looks like disallowing this was accidental rather than intentional. Make this work again.
tgummerer
added a commit
that referenced
this pull request
May 24, 2024
…events We only allow the `comment-on-pr` option inside of pull requests. This makes sense because we wouldn't be able to comment on anything otherwise. However with the `comment-on-pr-number` option gives us a PR number to comment on, so it can make sense with any type of GitHub actions event. This used to work before #813, and it looks like disallowing this was accidental rather than intentional. Make this work again.
tgummerer
added a commit
that referenced
this pull request
May 28, 2024
…events We only allow the `comment-on-pr` option inside of pull requests. This makes sense because we wouldn't be able to comment on anything otherwise. However with the `comment-on-pr-number` option gives us a PR number to comment on, so it can make sense with any type of GitHub actions event. This used to work before #813, and it looks like disallowing this was accidental rather than intentional. Make this work again.
tgummerer
added a commit
that referenced
this pull request
May 28, 2024
…events (#1178) We only allow the `comment-on-pr` option inside of pull requests. This makes sense because we wouldn't be able to comment on anything otherwise. However with the `comment-on-pr-number` option gives us a PR number to comment on, so it can make sense with any type of GitHub actions event. This used to work before #813, and it looks like disallowing this was accidental rather than intentional. Make this work again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.