Remove unused sshPrivateKey config #1176
Conversation
There was a problem hiding this comment.
In order to make the test job a shared workflow, the biggest blocker is the arbitary hooks (including pretest). The sshPrivateKey option was added as stop-gap solution to allow us to remove preTest in all providers.
PR introducing these options:
Unfortunately, having merged the preparation work, CI got de-prioritised and so the provider changes have not all been make to let us drop preTest.
I still think that getting rid of preTest is the right direction to be able to get the testing job as a reusable workflow. Perhaps worth a quick sync call on this to see if there's any other options.
|
@danielrbradley yeah that all sounds good. We can do this SSH setup in the docker tests directly, that way it won't need this hook or any other pretest stuff. |
There was a problem hiding this comment.
Great - happy with this now we've got a route to removing the preTest hook via pulumi/pulumi-docker#1300
Only the Docker provider uses the
webfactory/ssh-agentaction, and that's configured viapreTestinstead of the special-purposesshPrivateKeyoption.Nothing else appears to use this, so we can remove it.