Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused sshPrivateKey config #1176

Merged
merged 1 commit into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions provider-ci/internal/pkg/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,6 @@ type Config struct {
// https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22docker%3A%22&type=code
Docker bool `yaml:"docker"`

// SSHPrivateKey sets up SSH with specified private key before running
// tests in CI job. This should be provided from a secret. Used by the
// docker provider only:
// https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22sshPrivateKey%3A%22&type=code
SSHPrivateKey string `yaml:"sshPrivateKey"`

// GCP authenticates with GCP before running tests in CI job. Used in gcp
// and docker:
// https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22gcp%3A%22&type=code
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,6 @@ jobs:
- name: Login to Google Cloud Registry
run: gcloud --quiet auth configure-docker
#{{- end }}#
#{{- if .Config.SSHPrivateKey }}#
- name: Setup SSH key
uses: webfactory/ssh-agent@836c84ec59a0e7bc0eabc79988384eb567561ee2 # v0.7.0
with:
ssh-private-key: #{{ .Config.SSHPrivateKey }}#
#{{- end }}#
#{{- if index .Config.SetupScript }}#
- name: Run setup script
run: #{{ index .Config.SetupScript }}#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,6 @@ jobs:
- name: Login to Google Cloud Registry
run: gcloud --quiet auth configure-docker
#{{- end }}#
#{{- if .Config.SSHPrivateKey }}#
- name: Setup SSH key
uses: webfactory/ssh-agent@836c84ec59a0e7bc0eabc79988384eb567561ee2 # v0.7.0
with:
ssh-private-key: #{{ .Config.SSHPrivateKey }}#
#{{- end }}#
#{{- if index .Config.SetupScript }}#
- name: Run setup script
run: #{{ index .Config.SetupScript }}#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -139,12 +139,6 @@ jobs:
- name: Login to Google Cloud Registry
run: gcloud --quiet auth configure-docker
#{{- end }}#
#{{- if .Config.SSHPrivateKey }}#
- name: Setup SSH key
uses: webfactory/ssh-agent@836c84ec59a0e7bc0eabc79988384eb567561ee2 # v0.7.0
with:
ssh-private-key: #{{ .Config.SSHPrivateKey }}#
#{{- end }}#
#{{- if index .Config.SetupScript }}#
- name: Run setup script
run: #{{ index .Config.SetupScript }}#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,6 @@ jobs:
- name: Login to Google Cloud Registry
run: gcloud --quiet auth configure-docker
#{{- end }}#
#{{- if .Config.SSHPrivateKey }}#
- name: Setup SSH key
uses: webfactory/ssh-agent@836c84ec59a0e7bc0eabc79988384eb567561ee2 # v0.7.0
with:
ssh-private-key: #{{ .Config.SSHPrivateKey }}#
#{{- end }}#
#{{- if index .Config.SetupScript }}#
- name: Run setup script
run: #{{ index .Config.SetupScript }}#
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,6 @@ jobs:
- name: Login to Google Cloud Registry
run: gcloud --quiet auth configure-docker
#{{- end }}#
#{{- if .Config.SSHPrivateKey }}#
- name: Setup SSH key
uses: webfactory/ssh-agent@836c84ec59a0e7bc0eabc79988384eb567561ee2 # v0.7.0
with:
ssh-private-key: #{{ .Config.SSHPrivateKey }}#
#{{- end }}#
#{{- if index .Config.SetupScript }}#
- name: Run setup script
run: #{{ index .Config.SetupScript }}#
Expand Down
5 changes: 0 additions & 5 deletions provider-ci/internal/pkg/templates/defaults.config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,6 @@ checkUpstreamUpgrade: true
# Used in 9 providers: https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22docker%3A%22&type=code
#docker: false

# Setup SSH with specified private key before running tests in CI job.
# This should be provided from a secret
# Used by the docker provider only: https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22sshPrivateKey%3A%22&type=code
#sshPrivateKey: ${{ secrets.PRIVATE_SSH_KEY_FOR_DIGITALOCEAN }}

# Authenticate with GCP before running tests in CI job
# Used in gcp and docker: https://github.com/search?q=org%3Apulumi+path%3A.ci-mgmt.yaml+%22gcp%3A%22&type=code
#gcp: false
Expand Down
Loading