Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The api, deployment and stage outputs are returned as strings not objects #111

Open
lukehoban opened this issue Nov 24, 2023 · 0 comments
Open

The api, deployment and stage outputs are returned as strings not objects #111

lukehoban opened this issue Nov 24, 2023 · 0 comments
Labels
awaiting-core Awaiting features in pulumi/pulumi kind/bug Some behavior is incorrect or out of spec

Comments

@lukehoban
Copy link
Contributor

Currently most of the useful outputs on the RestAPI resources are returned as strings not objects.

This is the cause of these two issues:

pulumi-aws-apigateway/examples/simple/index.ts

Line 24 in d3f90fc

// TODO: re-enable once we establish why `api.api.id` is coming back as undefined

pulumi-aws-apigateway/provider/cmd/pulumi-resource-aws-apigateway/restAPI.ts

Lines 159 to 160 in d3f90fc

// TODO[pulumi/pulumi#7434]: Node.js does not yet deserialize `plain` inputs correctly,
// so we need to `apply` here.

I believe this is ultimately because of pulumi/pulumi#13802. We will need to fix that and then undo the workaround in restAPI.ts.
@lukehoban lukehoban added the kind/bug Some behavior is incorrect or out of spec label Nov 24, 2023
lukehoban added a commit that referenced this issue Nov 24, 2023
@lukehoban
Workaround #111
d32ec36
@lukehoban lukehoban mentioned this issue Nov 24, 2023
Merged
lukehoban pushed a commit that referenced this issue Nov 24, 2023
Fix support for apiKeySource (#112)
1b96058 
Ports the fix from pulumi/pulumi-awsx#1159 into this package.

Requires an awkward workaround for #111 (the workaround also takes a dependency on the currently broken behaviour, so this test will start failing when #111 is fixed).

Fixes #110.
@flostadler flostadler mentioned this issue May 17, 2024
Merged
@t0yv0 t0yv0 added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). awaiting-core Awaiting features in pulumi/pulumi and removed awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting-core Awaiting features in pulumi/pulumi kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t0yv0 @lukehoban