Enable tagging API gateway #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
reviewed
May 17, 2024
| @@ -485,111 +485,6 @@ export interface DeploymentArgs { | |||
| stageDescription?: pulumi.Input<string>; | |||
| } | |||
|
|
|||
| export class API extends pulumi.ComponentResource { | |||
There was a problem hiding this comment.
Surprising it was hanging around, but good to remove if unused!
t0yv0
reviewed
May 17, 2024
sdk/nodejs/restAPI.ts
Outdated
| @@ -148,4 +149,9 @@ export interface RestAPIArgs { | |||
| * Either `swaggerString` or `routes` must be specified. | |||
| */ | |||
| swaggerString?: pulumi.Input<string>; | |||
| /** | |||
| * 'Map of tags to assign to the resource. If configured with a provider `default_tags` configuration block present, | |||
There was a problem hiding this comment.
Prefer to inflect defaultTags? There is no one good answer here since default_tags is how it works in Python, but defaultTags is how it works in Node, but Node is more commonly used.
There was a problem hiding this comment.
I actually copied this from the docs of the underlying API gateway resource.
I wanted to stay in line with what we have on AWS classic, but I'm open to changing it if you think that'll be clearer
There was a problem hiding this comment.
Slight preference for defaultTags but no blocker.
t0yv0
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to tag the underlying resources of the API gateway component.
Closes #139
I cleaned up some dead code that was a leftover from extracting the API gateway component out of awsx. The resource
aws:apigateway:x:APIwas not exposed in this provider and thus not included in the SDKs.Note, the automated test is not working right now because of bug #111.
For verification I deployed an API gateway with tags and verified that they exist: