This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Pass hostPort explicitly in container definitions
#464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
reviewed
Apr 24, 2018
aws/service.ts
Outdated
| // However, if left blank, it will be automatically populated by AWS, potentially leading to dirty | ||
| // diffs even when no changes have been made. So we populate it with the same value as `containerPort`. | ||
| // See https://github.com/terraform-providers/terraform-provider-aws/issues/3401. | ||
| hostPort: p.targetPort || p.port, |
There was a problem hiding this comment.
Should we add a note about only doing this for networkMode: "awsvpc"?
There was a problem hiding this comment.
(I see that the doc snippet you pulled mentions it, but it's easy to miss)
mmdriley
approved these changes
Apr 24, 2018
lukehoban
force-pushed
the
lukehoban/hostport
branch
from
a51fa95 to
dbb960c
Compare
We've been seeing test flakiness when launching many tasks concurrently, likely related to #456. For now, simplify the test.
lukehoban
force-pushed
the
lukehoban/hostport
branch
from
cbb1c72 to
c8300b2
Compare
This was referenced May 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround hashicorp/terraform-provider-aws#3401.