Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for 0.12.1 #254

Merged
merged 5 commits into from
May 9, 2018
Merged

Updates for 0.12.1 #254

merged 5 commits into from
May 9, 2018

Conversation

lukehoban
Copy link
Contributor

@lukehoban lukehoban commented May 9, 2018 •
edited
Loading

Add changelog content and update version numbers for 0.12.1.

Not ready to merge - as the release has not yet been published - but sharing for review.

Updates for 0.12.1
989221b 
Add changelog content and update version numbers for 0.12.1.
@lukehoban lukehoban requested review from lindydonna and joeduffy May 9, 2018 05:45
justinvp
justinvp reviewed May 9, 2018
View reviewed changes
install/changelog.md Outdated

- Many enhancements to `pulumi new` ([pulumi/pulumi#1307](https://github.com/pulumi/pulumi/pull/1307)). The command now interactively walks through creating everything needed to deploy a new stack, including selecting a template, providing a name, creating a stack, setting default configuration, and installing dependencies.

- A new all-in-one installer script is now available at https://get.pulumi.com.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really matter, but I wonder if it'd be nicer to list these first three bullets in the order that they would be used, e.g. install -> pulumi new -> pulumi update.

lindydonna
lindydonna approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@lindydonna lindydonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinvp
Copy link
Member

justinvp commented May 9, 2018 •
edited
Loading

See 5edda7c for the Getting Started content.

Also (this isn't included in that commit) but the the older gettingStarted part can be deleted since it's now replaced by gettingStartedTerminal.

joeduffy
joeduffy reviewed May 9, 2018
View reviewed changes
dashboard.json
"title": "Pulumi 0.12.1 now available",
"url": "https://docs.pulumi.com/install/changelog.html#v121",
"date": "2018-05-09"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we unpublish 0.12.0, so we don't have any risk that LM will pick it up? (Or at least, not advertise it on this page?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a changelog and News perspective I wouldn't remove it - as it's part of the history of improvements.

We will not provide any direct links to download 0.12.0 from the docs page after these changes.

We could choose to unpublish as well if we want to be really paranoid. We shoudl wait until after we merge these changes so that links from docs site continue workin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok... but you have to realize there's a non-zero risk someone from LM is going to accidentally download it, and we will be left dealing with the fallout of previews doing updates ... may not happen, but given that Lucas already tried to roll ahead to 0.11.x, I wouldn't discount the possibility.

If we're doing this, by the way -- which I almost always agree with except for builds we've published that we explicitly know are trash -- why did all the historical versions go away?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure precisely which piece of content you are concerned about here. The dashboard news feed - which this comment is attached to - has only existed since 0.11.3, so only includes releases since then. It links to the chanelog sections, not to downloads.

The only links to historical downloads are at the top of the changelog, and only to the latest 0.10, 0.11 and 0.12 release respectively. So after these changes are merged, to my knowledge, there will be no links from this site to download 0.12.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should just merge as-is if there's no download link they might find.

install/index.md
@@ -1,6 +1,6 @@
---
title: "Installation and Setup"
installer_version: "0.12.0"
installer_version: "0.12.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment about this page: The "The current SDK version is XX" should probably come between the Installation and Setup and Mac and Linux Easy Install header. It links to the changelog which is interesting no matter how you are installing the product.

install/changelog.md Outdated

### Added

- A new all-in-one installer script is now available at https://get.pulumi.com.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I noticed that https://get.pulumi.com doesn't serve the text of the file, presumably because it is assumed to be binary. @ellismg was this intentional? If I go to https://get.docker.com I can see the contents of the file.

As such, and probably a good idea either way, I think I'd hyperlink this text to /install so as not to confuse someone who might try and copy and paste the link into a browser.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As such, and probably a good idea either way, I think I'd hyperlink this text to /install so as not to confuse someone who might try and copy and paste the link into a browser.

Good idea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellismg was this intentional? If I go to https://get.docker.com I can see the contents of the file.

It was not intentional. I suspect the reason this is happening is that the CloudFront is returning a different content type (application/x-shellscript vs text/plain, which is what docker uses), and the browser prefers to download that content type rather than display it.

Opened: pulumi/get.pulumi.com#5

install/changelog.md

- (**Breaking**) Removed the `LogCollector` and `onError` handler from `@pulumi-cloud` ([pulumi/pulumi-cloud#474](https://github.com/pulumi/pulumi-cloud/pull/474)). These were previously created in all stacks using `@pulumi/cloud`, but in practice were not being used.

### Fixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still long for a more complete list of commits. This list looks far more sparse than it ought to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add this? The majority of these are internal engineering things and most users do not have access to any of the links - but if we want to advertise the volume of work, this will do that.

Commits

pulumi/pulumi#1346: Fix preview against a PPC
pulumi/pulumi#1345: Make tokenSource.Close() synchronous.
pulumi/pulumi#1342: "Revert ""Revert the changes from #1261."""
pulumi/pulumi#1341: Capture Git committer and author info
pulumi/pulumi#1340: Support -y as shorthand for --yes
pulumi/pulumi#1339: Make the default pulumi new project description empty
pulumi/pulumi#1338: Simplify cmdutil.InitTracing.
pulumi/pulumi#1336: "Add ""Sign in to Pulumi"" to the login prompt"
pulumi/pulumi#1335: Avoid treating binary template files as text
pulumi/pulumi#1333: Restore streaming of plugin outputs to the progress display.
pulumi/pulumi#1332: Simplify code that decides to show stack outputs.
pulumi/pulumi#1330: Begin tracing Pulumi API calls.
pulumi/pulumi#1328: Enhance the engine's tracing support a bit.
pulumi/pulumi#1327: Print stack outputs at the end of an update.
pulumi/pulumi#1326: Cache workspaces based on full path.
pulumi/pulumi#1323: Remove test token
pulumi/pulumi#1322: Fix a typo.
pulumi/pulumi#1321: Run Configure calls in parallel
pulumi/pulumi#1319: Use git for detecting a dirty worktree.
pulumi/pulumi#1318: Add support for CPU and heap profiling.
pulumi/pulumi#1317: Enable tracing of integration tests.
pulumi/pulumi#1315: Make debuggable promise properties non-enumerable
pulumi/pulumi#1311: Support async function serialization.
pulumi/pulumi#1307: pulumi new improvements
pulumi/pulumi#1305: Put StartUpdateRequest in POST body
pulumi/pulumi#1304: Don't attempt to preview a destroy operation for a PPC hosted stack
pulumi/pulumi#1303: Fix Preview against a PPC
pulumi/pulumi#1302: Revert the changes from #1261.
pulumi/pulumi#1300: Invoke node directly from the language host
pulumi/pulumi#1299: Add necessary refresh apitypes
pulumi/pulumi#1297: Disable interactive mode for a CI/CD server.
pulumi/pulumi#1295: Use nicer URLs for stacks on the new identity model
pulumi/pulumi#1293: Improve two minor UX things in the CLI
pulumi/pulumi#1290: Revise the way previews are controlled
pulumi/pulumi#1289: Remove SDK dependencies
pulumi/pulumi#1288: Add commands to generate goodies
pulumi/pulumi#1287: Fix login/logout issue against non api.pulumi.com clouds
pulumi/pulumi#1286: Improve the error message if Pulumi runtime SDK isn't installed
pulumi/pulumi#1285: Fix an issue where errors outside of resource creation got dropped
pulumi/pulumi#1284: Remove pulumi history command
pulumi/pulumi#1283: Fix handling of nested archives
pulumi/pulumi#1282: Add static entries for Pulumi backends to /etc/hosts
pulumi/pulumi#1281: Use glog instead of printf
pulumi/pulumi#1277: "Pass ""special"" properties to Invoke."
pulumi/pulumi#1275: Add a URL column to stack ls.
pulumi/pulumi#1274: Minor CLI improvements
pulumi/pulumi#1273: Snapshot management overhaul and refactor
pulumi/pulumi#1271: Remove some obsolete flags from pulumi config rm
pulumi/pulumi#1267: Fix python package versions
pulumi/pulumi#1266: Require a resource's parent to actually be a resource.
pulumi/pulumi#1264: Fix update permalink for stacks on new identity model
pulumi/pulumi#1262: Add a hidden --no-interactive flag so that we can reduce interactive noise when running jenkins.
pulumi/pulumi#1261: Work around issue #1251.
pulumi/pulumi#1260: Add a new tree-view form for the progress view.
pulumi/pulumi#1254: Re-introduce interface for snapshot management
pulumi/pulumi-aws#205: Revert 2 PRs
pulumi/pulumi-aws#204: Enable tracing for integration tests.
pulumi/pulumi-aws#203: Make 'Function' a generic type
pulumi/pulumi-aws#202: Make serverless/function into a subclass of lambda/function.
pulumi/pulumi-cloud#480: Fix package publishing
pulumi/pulumi-cloud#478: Remove aws-infra from pulumi-cloud.
pulumi/pulumi-cloud#477: Use interface in place of class.
pulumi/pulumi-cloud#474: Remove LogCollector and onError
pulumi/pulumi-cloud#473: Enable tracing for integration tests.
pulumi/pulumi-cloud#472: Extract 'aws-infra' types into their own package independent of cloud-aws
pulumi/pulumi-cloud#470: Allow paging in Table.scan.
pulumi/pulumi-cloud#469: Use newer way of naming configuration
pulumi/pulumi-cloud#467: Don't yarn link @pulumi dependencies
pulumi/pulumi-cloud#465: Expose a 'defaultEndpoint' off of a Service to make consumption easier.
pulumi/pulumi-cloud#464: Pass hostPort explicitly in container definitions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels nice from an open source transparency perspective. Let's do it.

quickstart/aws-rest-api.md Outdated
let count = (value && value.count) || 0;
await counterTable.insert( { route, count: ++count });

res.status(200).json({ route, count});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, super minor formatting issue, missing a space between count and }.

More PR feedback
d493407 
Update dahsboard with new Getting Started content.

Add full changelog.
@ericrudder
Copy link
Member

ericrudder commented May 9, 2018 via email

@lukehoban
Copy link
Contributor Author

@joeduffy Please re-review now that the list of commits is here. I'm happy to keep this - it's a nice degree of transparency - but definitely worth making sure you feel okay with including this.

@joeduffy
Copy link
Member

joeduffy commented May 9, 2018

Love it, launch the missiles!

justinvp
justinvp reviewed May 9, 2018
View reviewed changes
dashboard.json Outdated
{ "title": "Introduction", "url": "https://docs.pulumi.com/concepts/" },
{ "title": "Programming Model", "url": "https://docs.pulumi.com/concepts/programming-model.html" },
{ "title": "Reference", "url": "https://docs.pulumi.com/reference" },
{ "title": "Learn about AWS", "url": "https://docs.pulumi.com/concepts/aws.html" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to to include links to Examples and Community Slack?

Tweak Documentation dashboard content
0e7246f 
Keep some of the changes made when we unified Docs and Getting Started cards, and simplify a bit.
justinvp
justinvp approved these changes May 9, 2018
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukehoban lukehoban merged commit bef8f48 into master May 9, 2018
@lukehoban lukehoban deleted the lukehoban/0.12.1 branch May 9, 2018 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellismg ellismg ellismg left review comments

@joeduffy joeduffy joeduffy left review comments

@lindydonna lindydonna lindydonna approved these changes

@justinvp justinvp justinvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lukehoban @justinvp @ericrudder @joeduffy @lindydonna @ellismg