Enhance the engine's tracing support a bit. #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pgavlin
commented
May 4, 2018
pgavlin
commented
- Allow callers to provide a parent span for the engine's operations
- Tag each plan context with the name of its associated operation
- Allow callers to provide a parent span for the engine's operations - Tag each plan context with the name of its associated operation
lukehoban
approved these changes
May 4, 2018
pkg/engine/refresh.go
Outdated
| @@ -15,7 +15,7 @@ func Refresh(u UpdateInfo, ctx *Context, opts UpdateOptions, dryRun bool) (Resou | |||
|
|
|||
| defer func() { ctx.Events <- cancelEvent() }() | |||
|
|
|||
| info, err := newPlanContext(u) | |||
| info, err := newPlanContext(u, "pulumi-refresh", ctx.ParentSpan) | |||
There was a problem hiding this comment.
Any reason this is pulumi- but the others are not?
There was a problem hiding this comment.
I thought I missed one of these. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.