Add support for CPU and heap profiling. #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add a new flag to the CLI, `--profiling`, that enables CPU and heap profiling of the CLI itself. The argument to this flag serves as a prefix for the CPU and heap profile outputs; these profiles are written to `[filename].[pid].cpu` and `[filename].[pid].mem`, respectively. These changes also fix an issue with `cmdutil.RunFunc` wherein any error would prevent the command's post-run hooks from executing.
lukehoban
reviewed
May 4, 2018
pkg/util/cmdutil/exit.go
Outdated
| @@ -46,13 +46,41 @@ func DetailedError(err error) string { | |||
| return msg | |||
| } | |||
|
|
|||
| func runPostCommandHooks(c *cobra.Command, args []string) error { | |||
There was a problem hiding this comment.
Perhaps add comment with a reference to the source of this logic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a new flag to the CLI,
--profiling, that enablesCPU and heap profiling of the CLI itself. The argument to this flag
serves as a prefix for the CPU and heap profile outputs; these profiles
are written to
[filename].[pid].cpuand[filename].[pid].mem,respectively.
These changes also fix an issue with
cmdutil.RunFuncwherein any errorwould prevent the command's post-run hooks from executing.