This repository was archived by the owner on Dec 16, 2024. It is now read-only.
Allow paging in Table.scan. #470
Merged
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an overload of Table.scan that accepts a callback that will be invoked as each page of results is fetched. If this callback returns `false`, no more pages will be fetched. These changes also fix a bug wherein the AWS implementation of Table.scan would not fetch all results if they had been paginated.
lukehoban
approved these changes
May 2, 2018
aws/table.ts
Outdated
| } | ||
| params.ExclusiveStartKey = result.LastEvaluatedKey; | ||
| } | ||
| return items; |
There was a problem hiding this comment.
Doing this unconditionally means the types sort of "lie". We will end up always returning an array - and perhaps surprisingly, an empty array in the case that you passed in a callback.
There was a problem hiding this comment.
I had not thought about doing this conditionally--I'll give that a shot.
| const db = await getDb(); | ||
| const result = await db.scan({ | ||
| const params: any = { |
There was a problem hiding this comment.
It's a shame we can't use a type annotation here, but I think due to the await import it isn't easy to name this.
There was a problem hiding this comment.
Yeah, I'm not sure how we'd type it.
| return items; | ||
| } else { | ||
| return; | ||
| } |
There was a problem hiding this comment.
note: tihs is effectively equivalent to just "return items";
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an overload of Table.scan that accepts a callback that will be
invoked as each page of results is fetched. If this callback returns
false, no more pages will be fetched.These changes also fix a bug wherein the AWS implementation of
Table.scan would not fetch all results if they had been paginated.