Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node root volume input properties added in the wrong place in the schema #820

Open
justinvp opened this issue Nov 23, 2022 · 0 comments
Open
Labels
area/multi-language-components kind/bug Some behavior is incorrect or out of spec

Comments

@justinvp
Copy link
Member

justinvp commented Nov 23, 2022

#641 added support for all EBS EC2 LaunchConfiguration params for EKS cluster node root volumes

The new input properties were added to NodeGroupBaseOptions in nodegroup.ts: https://github.com/pulumi/pulumi-eks/pull/641/files#diff-fa11b07a99c4eb8e85f987e265e143389230bafb7636b3b6bab10cf6158a120e

The input properties were also added to the schema, but in the wrong place: they were added to Cluster's input properties, not the NodeGroup's input properties. Cluster currently doesn't support these input properties in the implementation, so setting them from other languages has no effect.

We may indeed want these as top-level input properties for Cluster in addition to being available as inputs for NodeGroup, but that's currently not the case in the implementation.

We should fix all this to make sense, in both the implementation and in the schema, but in the meantime, we should simply remove these input properties from Cluster in the schema because they don't currently do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multi-language-components kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

1 participant