Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove input properties on Cluster that are not implemented #821

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Remove input properties on Cluster that are not implemented #821

merged 1 commit into from
Nov 23, 2022

Conversation

justinvp
Copy link
Member

These were added to the schema in the wrong place. Until we fix the implementation, these should be removed.

Part of #820

@github-actions
Copy link

Does the PR have any schema changes?

Found 5 breaking changes:
Resource "eks:index:Cluster" missing input "nodeRootVolumeEncrypted"
Resource "eks:index:Cluster" missing input "nodeRootVolumeType"
Resource "eks:index:Cluster" missing input "nodeRootVolumeDeleteOnTermination"
Resource "eks:index:Cluster" missing input "nodeRootVolumeThroughput"
Resource "eks:index:Cluster" missing input "nodeRootVolumeIops"
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Found 5 breaking changes:
Resource "eks:index:Cluster" missing input "nodeRootVolumeIops"
Resource "eks:index:Cluster" missing input "nodeRootVolumeDeleteOnTermination"
Resource "eks:index:Cluster" missing input "nodeRootVolumeEncrypted"
Resource "eks:index:Cluster" missing input "nodeRootVolumeType"
Resource "eks:index:Cluster" missing input "nodeRootVolumeThroughput"
No new resources/functions.

@justinvp
Remove input properties on Cluster that are not implemented
5c83cc1 
These were added to the schema in the wrong place. Until we fix the implementation, these should be removed.
@justinvp justinvp force-pushed the justin/noderootvolume branch from a913d62 to 5c83cc1 Compare November 23, 2022 03:27
@github-actions
Copy link

Does the PR have any schema changes?

Found 5 breaking changes:
Resource "eks:index:Cluster" missing input "nodeRootVolumeIops"
Resource "eks:index:Cluster" missing input "nodeRootVolumeThroughput"
Resource "eks:index:Cluster" missing input "nodeRootVolumeEncrypted"
Resource "eks:index:Cluster" missing input "nodeRootVolumeDeleteOnTermination"
Resource "eks:index:Cluster" missing input "nodeRootVolumeType"
No new resources/functions.

@danielrbradley danielrbradley merged commit 3d7338d into master Nov 23, 2022
@pulumi-bot pulumi-bot deleted the justin/noderootvolume branch November 23, 2022 12:02
flostadler pushed a commit that referenced this pull request Sep 4, 2024
@justinvp
Remove input properties on Cluster that are not implemented (#821)
0ccfbba 
These were added to the schema in the wrong place. Until we fix the implementation, these should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrbradley danielrbradley danielrbradley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinvp @danielrbradley