Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: support all EBS EC2 LaunchConfiguration params for EKS cluster node root volumes #641

Merged
merged 2 commits into from
Dec 3, 2021
Merged

nodejs: support all EBS EC2 LaunchConfiguration params for EKS cluster node root volumes #641

merged 2 commits into from
Dec 3, 2021

Conversation

con5cience
Copy link
Contributor

Proposed changes

Modify the NodeJS SDK to support all EC2 LaunchConfiguration parameters for EKS cluster node root volumes. This will enable users to configure any currently supported EBS volume type to power their EKS cluster nodes.

Related issues (optional)

#597

@github-actions
Copy link

github-actions bot commented Dec 1, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@con5cience con5cience changed the title nodejs: support all EC2 LaunchConfiguration params for EKS cluster node root volumes nodejs: support all EBS EC2 LaunchConfiguration params for EKS cluster node root volumes Dec 1, 2021
@con5cience con5cience force-pushed the nodejs-support-nodegroup-disk-types branch from c52d661 to 3a0a974 Compare December 1, 2021 20:40
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

lblackstone
lblackstone requested changes Dec 2, 2021
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The overall change makes sense to me, but I have a few comments to address.

nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
nodejs/eks/nodegroup.ts Show resolved Hide resolved
provider/cmd/pulumi-gen-eks/main.go Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

4 similar comments
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@con5cience con5cience force-pushed the nodejs-support-nodegroup-disk-types branch from e516b63 to 1587bbb Compare December 3, 2021 04:15
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@con5cience
Copy link
Contributor Author

Thanks for the PR! The overall change makes sense to me, but I have a few comments to address.

Thanks for your suggestions and guidance. I have updated the PR accordingly. Please feel free to suggest additional changes.

@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/1535210644

@lblackstone
Copy link
Member

It looks like the linter flagged a number of errors that will need to be fixed: https://github.com/pulumi/pulumi-eks/runs/4407997758?check_suite_focus=true#step:8:39

Also, you'll need to run make build to regenerate the SDKs with the schema changes.

@con5cience con5cience force-pushed the nodejs-support-nodegroup-disk-types branch from 1587bbb to b9cadf2 Compare December 3, 2021 15:35
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@con5cience con5cience force-pushed the nodejs-support-nodegroup-disk-types branch from b9cadf2 to 2437db8 Compare December 3, 2021 15:40
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/1536000488

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/1536147206

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/1536147206

lblackstone
lblackstone approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the PR!

@lblackstone lblackstone merged commit ae61f63 into pulumi:master Dec 3, 2021
@squaremo squaremo mentioned this pull request Nov 16, 2022
Merged
@roothorp roothorp mentioned this pull request Nov 21, 2022
Closed
@justinvp justinvp mentioned this pull request Nov 23, 2022
Open
flostadler pushed a commit that referenced this pull request Sep 4, 2024
@con5cience @lblackstone
nodejs: support all EBS EC2 LaunchConfiguration params for EKS cluste…
b84d9a8 
…r node root volumes (#641)

Co-authored-by: con5cience <con5cience@mailfence.com>
Co-authored-by: Levi Blackstone <levi@pulumi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

@viveklak viveklak Awaiting requested review from viveklak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@con5cience @lblackstone