Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nodegroup minsize and desiredsize #654

Merged
merged 3 commits into from
Feb 7, 2022
Merged

fix nodegroup minsize and desiredsize #654

merged 3 commits into from
Feb 7, 2022

Conversation

drunkirishcoder
Copy link
Contributor

Proposed changes

fixes bug #645. minSize and desiredSize of 0 not correctly supported.

Related issues (optional)

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

ctison
ctison reviewed Feb 4, 2022
View reviewed changes
nodejs/eks/nodegroup.ts Outdated Show resolved Hide resolved
@drunkirishcoder @ctison
more idiomatic ts code
9f8091a 
Co-authored-by: Charles Tison <ctison@pm.me>
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@drunkirishcoder
Copy link
Contributor Author

@leezen what's the review process to get this merged?

@leezen
Copy link
Contributor

leezen commented Feb 7, 2022

Oops -- looks like we approved but missed the merge. Thanks for pinging.

@leezen leezen merged commit 34643e9 into pulumi:master Feb 7, 2022
@drunkirishcoder drunkirishcoder deleted the fix-nodegroup-minsize branch February 8, 2022 20:48
@stack72 stack72 mentioned this pull request May 9, 2022
Closed
flostadler pushed a commit that referenced this pull request Sep 4, 2024
@drunkirishcoder @ctison
fix nodegroup minsize and desiredsize (#654)
f1083a3 
Co-authored-by: Charles Tison <ctison@pm.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctison ctison ctison left review comments

@viveklak viveklak viveklak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drunkirishcoder @leezen @viveklak @ctison