Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nodegroup minsize and desiredsize #654

Merged
merged 3 commits into from
Feb 7, 2022
Merged

fix nodegroup minsize and desiredsize #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8504a76
fix nodegroup minsize and desiredsize
drunkirishcoder Jan 27, 2022
9f8091a
more idiomatic ts code
drunkirishcoder Feb 4, 2022
22dea59
one more fix
drunkirishcoder Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## Unreleased
- Fix `ENABLE_PREFIX_DELEGATION` not working
[#646](https://github.com/pulumi/pulumi-eks/pull/646)
- Fix node group's `minSize` and `desiredSize` cannot be 0
[#645](https://github.com/pulumi/pulumi-eks/issues/645)

## 0.36.0 (Released December 3, 2021)
- Add support for all EC2 LaunchConfiguration EBS parameters related to cluster root node volumes
Expand Down
6 changes: 3 additions & 3 deletions nodejs/eks/nodegroup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,9 +904,9 @@ export function createManagedNodeGroup(name: string, args: ManagedNodeGroupOptio
scalingConfig: pulumi.all([
args.scalingConfig,
]).apply(([config]) => {
const desiredSize = config && config.desiredSize || 2;
const minSize = config && config.minSize || 1;
const maxSize = config && config.maxSize || 2;
const desiredSize = config?.desiredSize ?? 2;
const minSize = config?.minSize ?? 1;
const maxSize = config?.maxSize ?? 2;
return {
desiredSize: desiredSize,
minSize: minSize,
Expand Down