Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer set default value for AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER #737

Conversation

richerdavid
Copy link
Contributor

@richerdavid richerdavid commented Jul 14, 2022

Proposed changes

Fix an issue where the env var AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER can duplicated in aws-node daemonset and make helm apply fail. The regression has been introduced in 0.40.0.

Remove set default has it's already set in https://github.com/pulumi/pulumi-eks/blob/master/nodejs/eks/cni/aws-k8s-cni.yaml

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@roothorp
Copy link
Contributor

/run-acceptance-tests

@github-actions
Copy link

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@stack72
Copy link
Contributor

stack72 commented Jul 27, 2022

Thanks so much for this @richerdavid - we are happy to merge it and thank you for your time!

@stack72 stack72 merged commit 84dcb0f into pulumi:master Jul 27, 2022
@richerdavid richerdavid deleted the fix_duplicated_AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER branch August 16, 2022 11:50
flostadler pushed a commit that referenced this pull request Sep 4, 2024
)

Co-authored-by: Paul Stack <public@paulstack.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants