Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer set default value for AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER #737

Merged
merged 3 commits into from
Jul 27, 2022
Merged

No longer set default value for AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd958ad
No longer set default value for AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER
richerdavid Jul 14, 2022
72f7b9c
Updated CHANGELOG.md
richerdavid Jul 14, 2022
a36592f
Merge branch 'master' into fix_duplicated_AWS_VPC_K8S_CNI_CONFIGURE_R…
stack72 Jul 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## Unreleased
- Due to https://github.com/pulumi/pulumi/issues/7012 including the provider in the generated SDK never really worked. This is removed now. Note - existing uses in Nodejs should not be affected.
- BREAKING CHANGE: Due to https://github.com/pulumi/pulumi/issues/7012 including the provider in the generated SDK never really worked. This is removed now. Note - existing uses in Nodejs should not be affected.
[#746](https://github.com/pulumi/pulumi-eks/pull/746)
- Fix issue with duplicated AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER env var on aws-node daemonset.
[#737](https://github.com/pulumi/pulumi-eks/pull/737)

## 0.41.2 (Released Jul 12, 2022)
- Allow removal of default Kubernetes addons
Expand Down
2 changes: 0 additions & 2 deletions nodejs/eks/cmd/provider/cni.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,6 @@ function computeVpcCniYaml(cniYamlText: string, args: VpcCniInputs): string {
}
if (args.cniConfigureRpfilter) {
env.push({ name: "AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER", value: args.cniConfigureRpfilter ? "true" : "false" });
} else {
env.push({ name: "AWS_VPC_K8S_CNI_CONFIGURE_RPFILTER", value: "false" });
}
if (args.cniCustomNetworkCfg) {
env.push({ name: "AWS_VPC_K8S_CNI_CUSTOM_NETWORK_CFG", value: args.cniCustomNetworkCfg ? "true" : "false" });
Expand Down