Fix converter regression #777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
force-pushed
the
pprazak/774/fix-converter-regression
branch
from
b3fd8e7 to
9579962
Compare
pawelprazak
commented
Aug 10, 2022
| )); | ||
| } | ||
| setters.get(name).invoke(builder, argument); | ||
| var convertedArgument = tryConvertObjectInner( |
There was a problem hiding this comment.
this is the fix
pawelprazak
commented
Aug 10, 2022
| setters.get(name).getName(), | ||
| Nullable.class.getTypeName() | ||
| )); | ||
| } | ||
| try { |
There was a problem hiding this comment.
made try...catch more narrow
pawelprazak
commented
Aug 10, 2022
| @@ -396,33 +396,45 @@ private Object tryConvertObjectInner( | |||
| // call setters for all arguments | |||
| var setters = processSetters(builderType, Function.identity()); | |||
| argumentsMap.forEach((name, argument) -> { | |||
| if (!setters.containsKey(name)) { | |||
There was a problem hiding this comment.
moved from inside the try catch
pawelprazak
commented
Aug 10, 2022
| TypeShape.extract(extractSetterParameter(setters.get(name))) | ||
| ); | ||
| setters.get(name).invoke(builder, convertedArgument); | ||
| } catch (IllegalArgumentException e) { |
There was a problem hiding this comment.
added info to IAE for debugging, previously got only "type mismatch error" in this case
3 tasks
pawelprazak
force-pushed
the
pprazak/774/fix-converter-regression
branch
from
6201d7d to
432c858
Compare
|
merged with #782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit tests in separate PR: #782 on top of this one
Fixes #774
Checklist