Port custom types tests from old to new #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
force-pushed
the
pprazak/750/port-custom-types-tests-from-old-to-new
branch
2 times, most recently
from
7c7ab48 to
87f1268
Compare
pawelprazak
force-pushed
the
pprazak/750/port-custom-types-tests-from-old-to-new
branch
from
87f1268 to
e64e370
Compare
t0yv0
reviewed
Aug 10, 2022
|
|
||
| - [sdk] [#774](https://github.com/pulumi/pulumi-java/issues/774) | ||
| fixes deserialization regression in new codegen specific part of SDK, | ||
| complex @CustomType's are deserializable now |
There was a problem hiding this comment.
Seems duplicative changelog but I can tidy it up later before releasing
There was a problem hiding this comment.
yes, there were two regressions, the second one was just a debug message
There was a problem hiding this comment.
sorry, I missed it
There was a problem hiding this comment.
should be ok now
t0yv0
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
This fixes the following scenario for me:
pulumi new kubernetes-java
# edit pom.xml to ref pulumi 0.0.1 built from source
# edit pom.xml to ref latest kubernetes
mvn clean
pulumi preview
This works with pre-release but not released version of Pulumi. Good job.
pawelprazak
force-pushed
the
pprazak/750/port-custom-types-tests-from-old-to-new
branch
from
05a64f8 to
cfabacd
Compare
pulumi-bot
deleted the
pprazak/750/port-custom-types-tests-from-old-to-new
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On top of #777
Part of #750
Relates to #774
Checklist