LogRedirector panic #2697
Assignees
Labels
kind/bug
Some behavior is incorrect or out of spec
p1
A bug severe enough to be the next item assigned to an engineer
resolution/fixed
This issue was fixed
Comments
VenelinMartinov
added
the
p1
iwahbe
added a commit
that referenced
this issue
Dec 9, 2024
This change prevents test providers from being initialized with partially nil logging sinks, which panicked in tests. Happily, the problem is restricted to `MakeMuxedServer`, a testing API. This was never present in production code. Fixes #2697 --- This is [my least favorite go feature](https://www.iwahbe.com/blog/go-pointers-considered-confusing/).
iwahbe
added a commit
that referenced
this issue
Dec 9, 2024
This change prevents test providers from being initialized with partially nil logging sinks, which panicked in tests. Happily, the problem is restricted to `MakeMuxedServer`, a testing API. This was never present in production code. Fixes #2697 --- This is [my least favorite go feature](https://www.iwahbe.com/blog/go-pointers-considered-confusing/).
iwahbe
added a commit
that referenced
this issue
Dec 9, 2024
This change prevents test providers from being initialized with partially nil logging sinks, which panicked in tests. Happily, the problem is restricted to `MakeMuxedServer`, a testing API. This was never present in production code. Fixes #2697 --- This is [my least favorite go feature](https://www.iwahbe.com/blog/go-pointers-considered-confusing/).
iwahbe
added a commit
that referenced
this issue
Dec 9, 2024
This change prevents test providers from being initialized with partially nil logging sinks, which panicked in tests. Happily, the problem is restricted to `MakeMuxedServer`, a testing API. This was never present in production code. Fixes #2697 --- This is [my least favorite go feature](https://www.iwahbe.com/blog/go-pointers-considered-confusing/).
|
This issue has been addressed in PR #2699 and shipped in release v3.97.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
On the latest bridge one of the GCP tests fails reproducibly with a panic: https://github.com/pulumi/pulumi-gcp/actions/runs/12199367880/job/34039408594?pr=2708
Discovered in downstream tests for a bridge release.
Example
https://github.com/pulumi/pulumi-gcp/actions/runs/12199367880/job/34039408594?pr=2708
Output of
pulumi about.
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: