Avoid a partially nil host as sink in test muxed providers
#2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
approved these changes
Dec 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2699 +/- ##
==========================================
- Coverage 69.46% 69.46% -0.01%
==========================================
Files 301 301
Lines 38637 38644 +7
==========================================
+ Hits 26841 26845 +4
- Misses 10273 10275 +2
- Partials 1523 1524 +1 ☔ View full report in Codecov by Sentry. |
iwahbe
force-pushed
the
iwahbe/2697/avoid-partially-nil-host-interface
branch
from
0fa1f8d to
03503f7
Compare
Yes 😞 |
|
I've added a test and am merging now. I'll run tests for another bridge release as soon as this goes in. |
This change prevents test providers from being initialized with partially nil logging sinks, which panicked in tests. Happily, the problem is restricted to `MakeMuxedServer`, a testing API. This was never present in production code. Fixes #2697 --- This is [my least favorite go feature](https://www.iwahbe.com/blog/go-pointers-considered-confusing/).
iwahbe
force-pushed
the
iwahbe/2697/avoid-partially-nil-host-interface
branch
from
03503f7 to
17f803f
Compare
|
This PR has been shipped in release v3.97.0. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents test providers from being initialized with partially nil logging sinks, which panicked in tests. Happily, the problem is restricted to
MakeMuxedServer, a testing API. This was never present in production code.Fixes #2697