Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PF Diff cross tests #2578

Merged
merged 8 commits into from
Nov 5, 2024
Merged

PF Diff cross tests #2578

merged 8 commits into from
Nov 5, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Nov 1, 2024

This change adds the framework code for running Diff cross-tests in PF. It also adds a simple cross-test to show the framework works. I'll add additional coverage in a follow-up PR.

I've also exposed the Stdout output of both TF Plan and Pulumi Preview, so that they can be recorded in the cross-test. This will allow us to use the cross-tests for testing accurate bridge previews.

related to #2297

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Nov 1, 2024

This change is part of the following stack:

Change managed by git-spice.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 93.65079% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.93%. Comparing base (a2113d8) to head (5ec549b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/pf/tests/internal/cross-tests/diff.go 92.66% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2578      +/-   ##
==========================================
+ Coverage   62.82%   62.93%   +0.10%     
==========================================
  Files         387      388       +1     
  Lines       51717    51837     +120     
==========================================
+ Hits        32493    32625     +132     
+ Misses      17400    17385      -15     
- Partials     1824     1827       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov changed the title diff cross tests PF Diff cross tests Nov 4, 2024
@VenelinMartinov VenelinMartinov marked this pull request as ready for review November 4, 2024 13:05
pkg/pf/tests/internal/cross-tests/diff.go Outdated Show resolved Hide resolved
pkg/internal/tests/cross-tests/impl/diff.go Outdated Show resolved Hide resolved
@VenelinMartinov VenelinMartinov force-pushed the vvm/diff_cross_tests branch 2 times, most recently from 2c445f0 to c4b8162 Compare November 4, 2024 20:32
Base automatically changed from vvm/move_cross_test_pf_write_1 to master November 4, 2024 21:02
@VenelinMartinov VenelinMartinov merged commit b278128 into master Nov 5, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/diff_cross_tests branch November 5, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants