-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PF Diff cross tests #2578
Merged
Merged
PF Diff cross tests #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is part of the following stack: Change managed by git-spice. |
This was referenced Nov 1, 2024
VenelinMartinov
force-pushed
the
vvm/move_cross_test_pf_write_1
branch
from
November 1, 2024 19:46
ae6c2b7
to
de1e97c
Compare
VenelinMartinov
force-pushed
the
vvm/diff_cross_tests
branch
2 times, most recently
from
November 1, 2024 19:51
6e26db2
to
9d3502c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2578 +/- ##
==========================================
+ Coverage 62.82% 62.93% +0.10%
==========================================
Files 387 388 +1
Lines 51717 51837 +120
==========================================
+ Hits 32493 32625 +132
+ Misses 17400 17385 -15
- Partials 1824 1827 +3 ☔ View full report in Codecov by Sentry. |
iwahbe
approved these changes
Nov 4, 2024
VenelinMartinov
force-pushed
the
vvm/move_cross_test_pf_write_1
branch
from
November 4, 2024 20:21
6ffc645
to
77633e4
Compare
VenelinMartinov
force-pushed
the
vvm/diff_cross_tests
branch
2 times, most recently
from
November 4, 2024 20:32
2c445f0
to
c4b8162
Compare
VenelinMartinov
force-pushed
the
vvm/diff_cross_tests
branch
from
November 4, 2024 22:41
a865a2d
to
5ec549b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the framework code for running Diff cross-tests in PF. It also adds a simple cross-test to show the framework works. I'll add additional coverage in a follow-up PR.
I've also exposed the Stdout output of both TF Plan and Pulumi Preview, so that they can be recorded in the cross-test. This will allow us to use the cross-tests for testing accurate bridge previews.
related to #2297